GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-90622: Do not spawn ProcessPool workers on demand via the "fork" spawn method (GH-91598) by gpshead · Pull Request #92497 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented May 8, 2022

Copy link
Copy Markdown
Member

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gpshead
[3.10] pythongh-90622: Do not spawn ProcessPool workers on demand via…
5595472
… fork method. (pythonGH-91598)

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith <[email protected]>
@gpshead gpshead added type-bug An unexpected behavior, bug, or error needs backport to 3.9 labels May 8, 2022
@bedevere-bot bedevere-bot mentioned this pull request May 8, 2022
gh-90622: Do not spawn ProcessPool workers on demand via fork method. #91598
Merged
@bedevere-bot bedevere-bot added the awaiting core review label May 8, 2022
@gpshead
gpshead merged commit b795376 into python:3.10 May 8, 2022
@miss-islington

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label May 8, 2022
@gpshead
gpshead deleted the backport-ebb37fc-3.10 branch May 8, 2022 17:12
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2022
@gpshead @miss-islington
[3.10] pythongh-90622: Do not spawn ProcessPool workers on demand via…
ecfa914
… fork method. (pythonGH-91598) (pythonGH-92497)

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit b795376)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 8, 2022
@bedevere-bot

bedevere-bot commented May 8, 2022

Copy link
Copy Markdown

GH-92499 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead added a commit that referenced this pull request May 8, 2022
@miss-islington @gpshead
[3.10] gh-90622: Do not spawn ProcessPool workers on demand via fork …
8e523c1
…method. (GH-91598) (GH-92497) (#92499)

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit b795376)

Co-authored-by: Gregory P. Smith <[email protected]>

Co-authored-by: Gregory P. Smith <[email protected]>
@gpshead gpshead linked an issue May 8, 2022 that may be closed by this pull request
concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used #90622
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @gpshead @hello-adam
[3.10] pythongh-90622: Do not spawn ProcessPool workers on demand via…
78e11e4
… fork method. (pythonGH-91598) (pythonGH-92497) (python#92499)

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit b795376)

Co-authored-by: Gregory P. Smith <[email protected]>

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.