GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] [3.10] gh-90622: Do not spawn ProcessPool workers on demand via fork method. (GH-91598) (GH-92497) by miss-islington · Pull Request #92499 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith [email protected]
(cherry picked from commit b795376)

Co-authored-by: Gregory P. Smith [email protected]

Automerge-Triggered-By: GH:gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead @miss-islington
[3.10] pythongh-90622: Do not spawn ProcessPool workers on demand via…
ecfa914 
… fork method. (pythonGH-91598) (pythonGH-92497)

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit b795376)

Co-authored-by: Gregory P. Smith <[email protected]>
@miss-islington

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request May 8, 2022
[3.10] gh-90622: Do not spawn ProcessPool workers on demand via the "fork" spawn method (GH-91598) #92497
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels May 8, 2022
gpshead
gpshead approved these changes May 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 8, 2022
@gpshead gpshead added the 🤖 automerge label May 8, 2022
@gpshead gpshead self-assigned this May 8, 2022
@gpshead gpshead linked an issue May 8, 2022 that may be closed by this pull request
concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used #90622
Closed
@gpshead
gpshead merged commit 8e523c1 into python:3.9 May 8, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 8, 2022
@miss-islington
miss-islington deleted the backport-b795376-3.9 branch May 8, 2022 18:22
@miss-islington

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @gpshead @hello-adam
[3.10] pythongh-90622: Do not spawn ProcessPool workers on demand via…
78e11e4 
… fork method. (pythonGH-91598) (pythonGH-92497) (python#92499)

Do not spawn ProcessPool workers on demand when they spawn via fork.

This avoids potential deadlocks in the child processes due to forking from
a multithreaded process..
(cherry picked from commit ebb37fc)

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit b795376)

Co-authored-by: Gregory P. Smith <[email protected]>

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

concurrent.futures.ProcessPoolExecutor can deadlock when tcmalloc is used

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.