GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-93044: No longer convert the database argument of sqlite3.c… by serhiy-storchaka · Pull Request #93048 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 21, 2022

Copy link
Copy Markdown
Member

…onnect() to bytes (GH-93046)

Just pass it to the factory as is..
(cherry picked from commit 14c0d33)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.11] pythongh-93044: No longer convert the database argument of sql…
2caba36 
…ite3.connect() to bytes (pythonGH-93046)

Just pass it to the factory as is..
(cherry picked from commit 14c0d33)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka requested review from berkerpeksag and erlend-aasland as code owners May 21, 2022 12:37
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 21, 2022
@bedevere-bot bedevere-bot mentioned this pull request May 21, 2022
gh-93044: No longer convert the database argument of sqlite3.connect() to bytes #93046
Merged
@bedevere-bot bedevere-bot added the awaiting core review label May 21, 2022
erlend-aasland
erlend-aasland approved these changes May 21, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 21, 2022
@serhiy-storchaka
serhiy-storchaka merged commit d9a48d2 into python:3.11 May 21, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 21, 2022
@serhiy-storchaka
serhiy-storchaka deleted the backport-14c0d33-3.11 branch May 21, 2022 13:54
@erlend-aasland erlend-aasland mentioned this pull request May 21, 2022
Unintentional changes in sqlite3.connect() #93044
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.