GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-93044: No longer convert the database argument of sqlite3.connect() to bytes by serhiy-storchaka · Pull Request #93046 · python/cpython

Conversation

serhiy-storchaka commented May 21, 2022

Copy link

Copy Markdown

Member

Just pass it to the factory as is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-93044: No longer convert the database argument of sqlite3.co…

19c77f5

…nnect() to bytes

Just pass it to the factory as is.

serhiy-storchaka added type-bug

An unexpected behavior, bug, or error

needs backport to 3.11 only security fixes labels

May 21, 2022

serhiy-storchaka requested review from berkerpeksag and erlend-aasland as code owners

May 21, 2022 10:19

bedevere-bot added the awaiting core review label

May 21, 2022

serhiy-storchaka linked an issue

May 21, 2022

that may be closed by this pull request

Unintentional changes in sqlite3.connect() #93044

Closed

erlend-aasland commented May 21, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

I wonder if we should run this through the Django test suite as well; they've got a ton of sqlite3 tests there.

@felixxm, what do you think?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland approved these changes

May 21, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 21, 2022

serhiy-storchaka merged commit 14c0d33 into python:main

May 21, 2022

miss-islington commented May 21, 2022

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

May 21, 2022

miss-islington commented May 21, 2022

Copy link

Copy Markdown

Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 14c0d33016a967a98155f2e1615660e9328aef5d 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka deleted the sqlite-connect-factory-database-arg branch

May 21, 2022 11:35

miss-islington assigned serhiy-storchaka

May 21, 2022

felixxm commented May 21, 2022

Copy link

Copy Markdown

Contributor

I wonder if we should run this through the Django test suite as well; they've got a ton of sqlite3 tests there.

@felixxm, what do you think?

Will check.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels

May 21, 2022

miss-islington commented May 21, 2022

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented May 21, 2022

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 14c0d33016a967a98155f2e1615660e9328aef5d 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka mentioned this pull request

May 21, 2022

[3.11] gh-93044: No longer convert the database argument of sqlite3.c… #93048

Merged

bedevere-bot removed the needs backport to 3.11 only security fixes label

May 21, 2022

bedevere-bot commented May 21, 2022

Copy link

Copy Markdown

GH-93048 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

May 21, 2022


          [3.11] pythongh-93044: No longer convert the database argument of sql…

2caba36

…ite3.connect() to bytes (pythonGH-93046)

Just pass it to the factory as is..
(cherry picked from commit 14c0d33)

Co-authored-by: Serhiy Storchaka <[email protected]>

felixxm commented May 21, 2022

Copy link

Copy Markdown

Contributor

Django checked ✔️ no issues.

erlend-aasland reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented May 21, 2022

Copy link

Copy Markdown

Contributor

Django checked ✔️ no issues.

Thanks! Highly appreciated 🙏🏻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit that referenced this pull request

May 21, 2022


          [3.11] gh-93044: No longer convert the database argument of sqlite3.c…

d9a48d2

…onnect() to bytes (GH-93046) (GH-93048)

Just pass it to the factory as is.
(cherry picked from commit 14c0d33)

Co-authored-by: Serhiy Storchaka <[email protected]>

erlend-aasland mentioned this pull request

May 21, 2022

Unintentional changes in sqlite3.connect() #93044

Closed

serhiy-storchaka removed their assignment

Jun 21, 2022

Reviewers

erlend-aasland

erlend-aasland approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unintentional changes in sqlite3.connect()

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented May 21, 2022

Uh oh!

erlend-aasland commented May 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented May 21, 2022

Uh oh!

miss-islington commented May 21, 2022

Uh oh!

felixxm commented May 21, 2022

Uh oh!

miss-islington commented May 21, 2022

Uh oh!

miss-islington commented May 21, 2022

Uh oh!

bedevere-bot commented May 21, 2022

Uh oh!

felixxm commented May 21, 2022

Uh oh!

erlend-aasland commented May 21, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erlend-aasland commented May 21, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.