GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93939: Build most shared extensions without setup.py by tiran · Pull Request #93940 · python/cpython

Conversation

@tiran

@tiran tiran commented Jun 17, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Build shared extensions without distutils #93939

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Jun 17, 2022
@tiran

tiran commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

macOS builder fails with sed: 13: @sed.in.11268: extra characters at the end of h command in configure step. Could somebody with a Mac please debug the problem?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the gh-93939-setup-stdlib branch from 7cb1c1f to e45af20 Compare June 26, 2022 08:40
arhadthedev
arhadthedev reviewed Jun 26, 2022
View reviewed changes
Comment thread Tools/scripts/check_shared_ext.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the gh-93939-setup-stdlib branch 6 times, most recently from 27867a5 to ea81ed8 Compare June 28, 2022 20:29
@ned-deily

ned-deily commented Jun 28, 2022

Copy link
Copy Markdown
Member

macOS builder fails with sed: 13: @sed.in.11268: extra characters at the end of h command in configure step. Could somebody with a Mac please debug the problem?

macOS uses a BSD-based version of sed and apparently an old version at that. There are a number of documented differences among the various versions and I think you are running into one by trying to do the multi-line append here:

		echo "/Definitions added by makesetup/a$NL$NL$DEFS" >>$sedf
		cat $sedf

Searching the web, there are various ways suggested to do this in a manner that will work with all versions. One simple way that seemed to work with both the macOS and GNU versions is to write the contents of $DEFS to another temp file and then use the sed r command instead of a to insert them.

tiran and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran mentioned this pull request Jun 29, 2022
makesetup can fail on macOS and uses wrong CFLAGS #94404
Closed
@tiran

tiran commented Jun 29, 2022

Copy link
Copy Markdown
Member Author

Thanks @ned-deily! sed r command works like a charm.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
tiran force-pushed the gh-93939-setup-stdlib branch from 60d4b36 to 4af2830 Compare June 29, 2022 08:14
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@bedevere-bot

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 4af2830c1cdfdc4a3a0fc0e5a8f491fa09301b14 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@tiran
tiran force-pushed the gh-93939-setup-stdlib branch from 4af2830 to 6502e8c Compare June 29, 2022 10:11
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@bedevere-bot

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 6502e8c76540e19b489e8aab31801d88cf1986ed 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
tiran added 6 commits June 29, 2022 15:47
@tiran
pythongh-93939: Build most shared extensions without setup.py
cfb33e6
@tiran
Fix generate_stdlib_module_names script to use Makefile
0e91b39
@tiran
variable has been renamed
f22f837
@tiran
blurb
80894ee
@tiran
Improve check_modules script
ef08a28
@tiran
Fail on failing makesetup
e23a5dd
@tiran
tiran force-pushed the gh-93939-setup-stdlib branch from 6502e8c to e23a5dd Compare June 29, 2022 13:47
@tiran tiran mentioned this pull request Jul 1, 2022
gh-93939: Build C extensions without setup.py #94474
Merged
@tiran

tiran commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

The PR was an experiment. I'll open a proper PR when everything is in place.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran tiran closed this Jul 5, 2022
miss-islington pushed a commit that referenced this pull request Jul 14, 2022
@tiran
gh-93939: Build C extensions without setup.py (GH-94474)
81dca70
Combines GH-93940, GH-94452, and GH-94433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @ned-deily @bedevere-bot @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.