GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90005: Port _dbm module to PY_STDLIB_MOD (GH-94433) by tiran · Pull Request #94433 · python/cpython

Conversation

@tiran

@tiran tiran commented Jun 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Port module setup to PY_STDLIB_MOD() macro and addext() #90005

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Jun 30, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2022
@bedevere-bot

bedevere-bot commented Jun 30, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 9a3def1410262b71c42db9b21e49fcd413d0173a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2022
@tiran
tiran requested a review from erlend-aasland June 30, 2022 19:31
@tiran
tiran marked this pull request as ready for review June 30, 2022 19:35
@tiran
pythongh-90005: Port _dbm module to PY_STDLIB_MOD
ad90c1e
@tiran
tiran force-pushed the gh-90005-dbm branch from 9a3def1 to ad90c1e Compare July 1, 2022 07:53
@tiran tiran mentioned this pull request Jul 1, 2022
gh-93939: Build C extensions without setup.py #94474
Merged
erlend-aasland
erlend-aasland approved these changes Jul 1, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as far as I can see

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 1, 2022
@tiran tiran changed the title gh-90005: Port _dbm module to PY_STDLIB_MOD gh-90005: Port _dbm module to PY_STDLIB_MOD (GH-94433) Jul 1, 2022
@tiran
tiran merged commit ec5e253 into python:main Jul 1, 2022
@tiran
tiran deleted the gh-90005-dbm branch July 1, 2022 19:48
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 1, 2022
miss-islington pushed a commit that referenced this pull request Jul 14, 2022
@tiran
gh-93939: Build C extensions without setup.py (GH-94474)
81dca70 
Combines GH-93940, GH-94452, and GH-94433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.