GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-54781: Mention sqlite3 test relocation in What's New by erlend-aasland · Pull Request #95059 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Move test sub-packages to Lib/test #54781

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
bpo-10572: Mention sqlite3 test relocation in What's New
6c6de0a
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news awaiting core review labels Jul 20, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 20, 2022
[3.11] bpo-10572: Mention sqlite3 test relocation in What's New #95053
Closed
@erlend-aasland
erlend-aasland requested a review from terryjreedy July 20, 2022 16:22
@erlend-aasland erlend-aasland added the needs backport to 3.11 only security fixes label Jul 20, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 20, 2022
bpo-10572: Move sqlite3 tests to Lib/test #29304
Merged
@erlend-aasland erlend-aasland changed the title bpo-10572: Mention sqlite3 test relocation in What's New gh-54781: Mention sqlite3 test relocation in What's New Jul 20, 2022
erlend-aasland and others added 2 commits July 20, 2022 18:29
@erlend-aasland
Try using correct gh number
f4280c9
@terryjreedy
Add periods to Contributed notes.
0167966
@zware

zware commented Jul 20, 2022

Copy link
Copy Markdown
Member

I'm not sure this is really necessary. We haven't mentioned other, even major, test changes in whatsnew, and test code is explicitly documented as non-public.
kumaraditya303 and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

I'm not sure this is really necessary. We haven't mentioned other, even major, test changes in whatsnew, and test code is explicitly documented as non-public.

Right, thanks for the historical context. If so, I believe it is better to close this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added pending The issue will be closed if no feedback is provided DO-NOT-MERGE labels Jul 20, 2022
terryjreedy
terryjreedy approved these changes Jul 20, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 20, 2022
@terryjreedy

terryjreedy commented Jul 20, 2022

Copy link
Copy Markdown
Member

The changelog has a Tests section. If there is really a policy against mentioning anything about tests in What's New, I won't argue for this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware

zware commented Jul 20, 2022

Copy link
Copy Markdown
Member

The changelog has a Tests section. If there is really a policy against mentioning anything about tests in What's New, I won't argue for this.

A mention in NEWS certainly makes sense, but I don't think it's worth an entry in whatsnew.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

A mention in NEWS certainly makes sense, but I don't think it's worth an entry in whatsnew.

"No sweat, I'll make him into a disciple." 🎨 🖌️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland removed needs backport to 3.11 only security fixes pending The issue will be closed if no feedback is provided labels Jul 20, 2022
@erlend-aasland

erlend-aasland commented Jul 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'll create a new PR against 3.11 for the NEWS entry, then. UPDATE:

  • [3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation #95061
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Jul 20, 2022
@erlend-aasland
erlend-aasland deleted the mention-sqlite-test-move branch July 20, 2022 18:05
@zware zware removed the awaiting merge label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DO-NOT-MERGE docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @zware @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.