GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation by erlend-aasland · Pull Request #95061 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Move test sub-packages to Lib/test #54781

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-54781: Add NEWS entry for sqlite3 test relocation
e8e96ca
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 20, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 20, 2022
gh-54781: Mention sqlite3 test relocation in What's New #95059
Closed
@erlend-aasland
erlend-aasland requested a review from terryjreedy July 20, 2022 17:57
@erlend-aasland erlend-aasland changed the title gh-54781: Add NEWS entry for sqlite3 test relocation [3.11] gh-54781: Add NEWS entry for sqlite3 test relocation Jul 20, 2022
@zware

zware commented Jul 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The original PR GH-29304 had a NEWS entry now enshrined in Misc/NEWS.d/3.11.0a2.rst. See https://docs.python.org/3.11/whatsnew/changelog.html#id67 (though it does look like it was put in Library rather than Tests).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

The original PR GH-29304 had a NEWS entry now enshrined in Misc/NEWS.d/3.11.0a2.rst. See https://docs.python.org/3.11/whatsnew/changelog.html#id67 (though it does look like it was put in Library rather than Tests).

Right; what a mess I'm making here :) Sorry for all the noise. I'll blame the heat 🥵 Let's move it to the Tests category then; that seems like a better fit for that changelog item

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 2 commits July 20, 2022 20:26
@erlend-aasland
Remove duplicate NEWS entry
003b524
@erlend-aasland
Move NEWS item to Tests, and improve wording
219ce67
@erlend-aasland erlend-aasland added the skip news label Jul 20, 2022
@erlend-aasland

erlend-aasland commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

PTAL; moved and improved.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland changed the title [3.11] gh-54781: Add NEWS entry for sqlite3 test relocation [3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation Jul 20, 2022
zware
zware reviewed Jul 20, 2022
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should be done on main and backported (this NEWS file also exists on main).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland

erlend-aasland commented Jul 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Of course; thanks for the heads-up. See:

  • gh-54781: Relocate and improve NEWS item for sqlite3 test relocation #95063
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland closed this Jul 20, 2022
@erlend-aasland
erlend-aasland deleted the 3.11-sqlite-test-move-news branch July 20, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments
@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @zware @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.