GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-95273: Move sqlite3 executemany examples from reference to tutorial by erlend-aasland · Pull Request #95351 · python/cpython Conversation
|
|
My 2 cents: The executemany examples are way more complex than the average user needs. We should focus on the sqlite3 module; not on writing fancy iterators. The only thing that bothers me, is that we do not explicitly mention that the cursor can be used as an iterator. We could add a mention in the cursor class description. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments, otherwise LGTM. Thanks @erlend-aasland !
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: CAM Gerlach <[email protected]>
Co-authored-by: CAM Gerlach <[email protected]>
There was an error while loading. Please reload this page.
I've already got this covered in the #95273 todo list. UPDATE: PR => #95379 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've got quite a lot on at the moment, so I'll leave this one in @CAM-Gerlach's very capable hands, if that's okay! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I wonder if it may make sense to keep a minimum example in the reference, though. The two previous examples ate more than a screenful. How about leaving something like this: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
SGTM; concise examples can certainly be helpful to aiding understanding and this one certainly helps me understand the purpose of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @erlend-aasland 👍
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…utorial (pythonGH-95351) (cherry picked from commit f0bf795) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95420 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…utorial (pythonGH-95351) (cherry picked from commit f0bf795) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95421 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
GH-95351) (cherry picked from commit f0bf795) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
GH-95351) (cherry picked from commit f0bf795) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Improve the sqlite3 reference
There was an error while loading. Please reload this page.