GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95273: Improve sqlite3 class descriptions by erlend-aasland · Pull Request #95379 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve the sqlite3 reference #95273

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-95273: Improve sqlite3 class descriptions
4e72a1a
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner July 28, 2022 12:34
@erlend-aasland erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes labels Jul 28, 2022
@erlend-aasland
erlend-aasland requested a review from CAM-Gerlach July 28, 2022 12:34
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 28, 2022
@erlend-aasland

erlend-aasland commented Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

I'm not satisfied with the connection and cursor wordings, but this is as far as I could get. I've borrowed slightly from the SQLite docs and PEP 249.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Jul 28, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Jul 28, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jul 28, 2022
Improve the sqlite3 reference #95273
Closed
gh-95273: Move sqlite3 executemany examples from reference to tutorial #95351
Merged
CAM-Gerlach
CAM-Gerlach reviewed Jul 29, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of minor comments, but otherwise LGTM—thanks, @erlend-aasland

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Address review
7407e05
@erlend-aasland
erlend-aasland requested a review from CAM-Gerlach July 29, 2022 07:59
@erlend-aasland

erlend-aasland commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

I've addressed all review comments; will land as soon as the CI is green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Jul 29, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland
Update Doc/library/sqlite3.rst
dd332be
erlend-aasland
erlend-aasland commented Jul 29, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland
Update Doc/library/sqlite3.rst
9d08323
@erlend-aasland
erlend-aasland merged commit e003b64 into python:main Jul 29, 2022
@miss-islington

miss-islington commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 29, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-reference/class-description branch July 29, 2022 09:53
@bedevere-bot

bedevere-bot commented Jul 29, 2022

Copy link
Copy Markdown

GH-95425 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
Erlend Egeberg Aasland @miss-islington
pythongh-95273: Improve sqlite3 class descriptions (pythonGH-95379)
2cee5f3 
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2022
Erlend Egeberg Aasland @miss-islington
pythongh-95273: Improve sqlite3 class descriptions (pythonGH-95379)
c92fec9 
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 29, 2022

Copy link
Copy Markdown

GH-95426 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jul 29, 2022
miss-islington added a commit that referenced this pull request Jul 29, 2022
@miss-islington Erlend Egeberg Aasland
gh-95273: Improve sqlite3 class descriptions (GH-95379)
a41b51d 
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
miss-islington added a commit that referenced this pull request Jul 29, 2022
@miss-islington Erlend Egeberg Aasland
gh-95273: Improve sqlite3 class descriptions (GH-95379)
c26470f 
Co-authored-by: CAM Gerlach <[email protected]>
(cherry picked from commit e003b64)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland erlend-aasland linked an issue Aug 1, 2022 that may be closed by this pull request
Improve the sqlite3 reference #95273
Closed
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the sqlite3 reference

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.