GeezerVison is showing github.com — gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006) by tiran · Pull Request #96006 · python/cpython
Conversation
tiran
commented
Aug 15, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
- On WASI
ENOTCAPABLE is now mapped to PermissionError.
- The
errno modules exposes the new error number.
getpath.py now ignores PermissionError when it cannot open landmark
files pybuilddir.txt and pyenv.cfg.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`.
- The `errno` modules exposes the new error number.
- `getpath.py` now ignores `PermissionError` when it cannot open landmark
files `pybuilddir.txt` and `pyenv.cfg`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@pablogsal RM, is this an acceptable change for 3.11.0, should I delay it for 3.11.1, or only apply it to 3.12?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pablogsal
commented
Aug 16, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
@pablogsal RM, is this an acceptable change for 3.11.0, should I delay it for 3.11.1, or only apply it to 3.12?
This is likely too big for 3.11.0 :( are you ok delaying this to 3.11.1?
|
tiran reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This is likely too big for 3.11.0 :( are you ok delaying this to 3.11.1?
Sure, no problem! I'll update the docs.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tiran
changed the title
gh-96005: Handle WASI ENOTCAPABLE in getpath
gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006)
Aug 16, 2022
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2022
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`.
- The `errno` modules exposes the new error number.
- `getpath.py` now ignores `PermissionError` when it cannot open landmark
files `pybuilddir.txt` and `pyenv.cfg`.
(cherry picked from commit 48174fa)
Co-authored-by: Christian Heimes <[email protected]>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot AMD64 FreeBSD Non-Debug 3.x has failed when building commit 48174fa.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/172/builds/2715) and take a look at the build logs.
- Check if the failure is related to this commit (48174fa) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/all/#builders/172/builds/2715
Failed tests:
Failed subtests:
- test_errno_mapping - test.test_exception_hierarchy.HierarchyTest.test_errno_mapping
Summary of the results of the build (if available):
== Tests result: FAILURE then FAILURE ==
415 tests OK.
10 slowest tests:
- test_multiprocessing_spawn: 4 min 27 sec
- test_concurrent_futures: 3 min 15 sec
- test_asyncio: 2 min 49 sec
- test_unparse: 2 min 24 sec
- test_tokenize: 1 min 58 sec
- test_multiprocessing_forkserver: 1 min 53 sec
- test_venv: 1 min 48 sec
- test_multiprocessing_fork: 1 min 43 sec
- test_capi: 1 min 36 sec
- test_gdb: 1 min 21 sec
1 test failed:
test_exception_hierarchy
19 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_idle test_ioctl
test_launcher test_msilib test_spwd test_startfile test_tcl
test_tix test_tkinter test_ttk test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64
1 re-run test:
test_exception_hierarchy
Total duration: 15 min 56 sec
Click to see traceback logs
Traceback (most recent call last):
File "/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/Lib/test/test_exception_hierarchy.py", line 94, in test_errno_mapping
self.assertIs(type(e), OSError)
AssertionError: <class 'PermissionError'> is not <class 'OSError'>
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@tiran That looks like a genuine failure
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tiran
added a commit
that referenced
this pull request
Sep 13, 2022
) (GH-96038)
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`.
- The `errno` modules exposes the new error number.
- `getpath.py` now ignores `PermissionError` when it cannot open landmark
files `pybuilddir.txt` and `pyenv.cfg`.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|