GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034) by tiran · Pull Request #96034 · python/cpython

Conversation

@tiran

@tiran tiran commented Aug 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [WASI] getpath.py does not handle "Capabilities insufficient" (ENOTCAPABLE) #96005

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-96005: FreeBSD has ENOTCAPABLE, too
0e36363
@tiran
tiran requested a review from pablogsal August 16, 2022 20:04
@tiran
tiran requested a review from iritkatriel as a code owner August 16, 2022 20:04
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 16, 2022
@tiran

tiran commented Aug 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Problem: FreeBSD has ENOTCAPABLE, too. This means that the original changeset maps ENOTCAPABLE to PermissionError on FreeBSD as well. We never wrapped the errno, so it should be ok.

     93	ENOTCAPABLE Capabilities insufficient.	An operation on	a capability
	     file descriptor requires greater privilege	than the capability
	     allows.

https://www.freebsd.org/cgi/man.cgi?query=errno&sektion=2&manpath=freebsd-release-ports
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 16, 2022
@bedevere-bot

bedevere-bot commented Aug 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 0e36363 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 16, 2022
@tiran tiran changed the title gh-96005: FreeBSD has ENOTCAPABLE, too gh-96005: FreeBSD has ENOTCAPABLE, too (GH-96034) Aug 17, 2022
@tiran
tiran merged commit da0aa51 into python:main Aug 17, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 17, 2022
@tiran
tiran deleted the gh-96005-bsd branch August 17, 2022 05:24
@tiran tiran added the needs backport to 3.11 only security fixes label Aug 17, 2022
@miss-islington

miss-islington commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da0aa518bf5e6ac9de444a405c40649cfb0245eb 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran Aug 17, 2022
@tiran tiran removed the needs backport to 3.11 only security fixes label Aug 17, 2022
tiran added a commit to tiran/cpython that referenced this pull request Aug 17, 2022
@tiran
pythongh-96005: FreeBSD has ENOTCAPABLE, too (pythonGH-96034)
5f4adff
tiran added a commit that referenced this pull request Sep 13, 2022
@tiran
[3.11] gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006) (GH-96034
bc337a7 
) (GH-96038)

- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`.
- The `errno` modules exposes the new error number.
- `getpath.py` now ignores `PermissionError` when it cannot open landmark
  files `pybuilddir.txt` and `pyenv.cfg`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.