GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96288: Add a sentence to `os.mkdir`'s docstring. by hagai-helman · Pull Request #96271 · python/cpython

Conversation

@hagai-helman

@hagai-helman hagai-helman commented Aug 25, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

A clarification about the use of umask (copied from the os module documentation) is added to the docstring of os.mkdir.

The behavior described may be unexpected for some (for example, this is not the behavior of GNU's mkdir command - when a mode is explicitly given to it, it overrides the umask). When one is unaware of this behavior, it can lead to bugs that are difficult to notice or trace. For these two reasons, I suggest it is mentioned in the docstring.

  • Issue: The docstring for os.mkdir should mention the effect of umask #96288

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hagai-helman
Add a sentence to os.mkdir's docstring.
7ac0781
@bedevere-bot

bedevere-bot commented Aug 25, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Aug 25, 2022
@ghost

ghost commented Aug 25, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mdboom
mdboom requested changes Aug 25, 2022
View reviewed changes

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is editing the docstring in generated output.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/clinic/posixmodule.c.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Aug 25, 2022
@hagai-helman
Move the docstring change to the clinic input.
ff2eef1
@bedevere-bot

bedevere-bot commented Aug 25, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hagai-helman
Merge branch 'main' into main
c83add5
@bedevere-bot

bedevere-bot commented Aug 25, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the skip news label Aug 25, 2022
@hagai-helman
Merge branch 'main' into main
8aee00f
@hagai-helman hagai-helman mentioned this pull request Aug 25, 2022
The docstring for os.mkdir should mention the effect of umask #96288
Closed
@hagai-helman hagai-helman changed the title Add a sentence to os.mkdir's docstring. gh-96288: Add a sentence to os.mkdir's docstring. Aug 25, 2022
@JelleZijlstra

JelleZijlstra commented Oct 7, 2022

Copy link
Copy Markdown
Member

The change looks good (sorry for the wait!) but there's a merge conflict in the AC output. Could you merge main in and re-generate the AC output file?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra self-assigned this Oct 7, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 7, 2022
hagai-helman added 2 commits October 7, 2022 21:47
@hagai-helman
Merge and regenerate clinic output
285fefa
@hagai-helman
Merge branch 'main' into main
7754070
JelleZijlstra
JelleZijlstra approved these changes Oct 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 7, 2022
@JelleZijlstra
JelleZijlstra merged commit 1523c9e into python:main Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @hagai-helman for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Sorry, @hagai-helman and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1523c9e9d47e7d67e4889987ff0f38eb7b881fdd 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Sorry @hagai-helman and @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1523c9e9d47e7d67e4889987ff0f38eb7b881fdd 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 7, 2022
@hagai-helman @JelleZijlstra
[3.11] pythongh-96288: Add a sentence to os.mkdir's docstring. (pyt…
47141fe 
…honGH-96271).

(cherry picked from commit 1523c9e)

Co-authored-by: Hagai Helman Tov <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 7, 2022
@bedevere-bot

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98065 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 7, 2022
@bedevere-bot

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98066 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Oct 7, 2022
@hagai-helman @JelleZijlstra
[3.10] pythongh-96288: Add a sentence to os.mkdir's docstring. (pyt…
4c29f0f 
…honGH-96271).

(cherry picked from commit 1523c9e)

Co-authored-by: Hagai Helman Tov <[email protected]>
JelleZijlstra added a commit that referenced this pull request Oct 8, 2022
@JelleZijlstra @hagai-helman
[3.10] gh-96288: Add a sentence to os.mkdir's docstring. (GH-96271). (
2090eeb 
#98066)

(cherry picked from commit 1523c9e)

Co-authored-by: Hagai Helman Tov <[email protected]>
JelleZijlstra added a commit that referenced this pull request Oct 8, 2022
@JelleZijlstra @hagai-helman
[3.11] gh-96288: Add a sentence to os.mkdir's docstring. (GH-96271). (
1573211 
#98065)

(cherry picked from commit 1523c9e)

Co-authored-by: Hagai Helman Tov <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
27a4980 
* main: (38 commits)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)
  pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)
  pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)
  pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)
  pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)
  pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)
  pythonGH-88968: Reject socket that is already used as a transport (python#98010)
  pythongh-96346: Use double caching for re._compile() (python#96347)
  pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)
  pythongh-96265: Fix some formatting in faq/design.rst (python#96924)
  pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)
  pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)
  pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)
  pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)
  pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@hagai-helman @mpage
pythongh-96288: Add a sentence to os.mkdir's docstring. (python#96271)
b9bd94d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom requested changes
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hagai-helman @bedevere-bot @JelleZijlstra @miss-islington @mdboom @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.