GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-97956: Mention `generate_global_objects.py` in `AC How-To` by sobolevn · Pull Request #97957 · python/cpython

Conversation

sobolevn commented Oct 6, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: "Argument Clinic How-To" misses generate_global_objects step #97956

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-97956: Mention generate_global_objects.py in AC How-To

f130f74

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Oct 6, 2022

sobolevn commented Oct 6, 2022

Copy link

Copy Markdown

Member Author

Looks like GitHub Actions are broken right now. I will re-run the CI a bit later.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn commented Oct 6, 2022

Copy link

Copy Markdown

Member Author

Re-triggering

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn closed this

Oct 6, 2022

sobolevn reopened this

Oct 6, 2022

blockchainGuru1018 approved these changes

Oct 6, 2022

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels

Oct 6, 2022

larryhastings reviewed

Oct 6, 2022

View reviewed changes

larryhastings left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to add this step to the documentation. But I have some suggestions on how to rewrite the text to make it a little clearer. Please take a look!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/howto/clinic.rst Outdated



		16. Compile, then run the relevant portions of the regression-test suite.
		16. Code generated by Argument Clinic might use ``_Py_ID`` macro inside.

larryhastings Oct 6, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument Clinic may generate new instances of _Py_ID. For example::

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/howto/clinic.rst Outdated


		&_Py_ID(new_unique_py_id)

		It means that you would need to run ``Tools/scripts/generate_global_objects.py``

larryhastings Oct 6, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does, you'll have to run Tools/scripts/generate_global_objects.py to regenerate the list of precompiled identifiers at this point.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sobolevn Oct 6, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

It is always great to have native-speakers to double check things like this. I think in another language and it does not translate that well into English in some cases :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sobolevn added 2 commits

October 6, 2022 22:27


          Address review

f1a23cb


          Merge branch 'main' into patch-11

ad3816b

sobolevn commented Oct 6, 2022

Copy link

Copy Markdown

Member Author

Looks like the CI failure is somehow related to f612565

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JulienPalard commented Oct 7, 2022

Copy link

Copy Markdown

Member

@sobolevn I think that the CI issues has been fixed (sphinx-lint side for some false postives, and cpython side for the few true positives), can you please rebase your branch on top of main?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn closed this

Oct 7, 2022

sobolevn reopened this

Oct 7, 2022


          Merge branch 'main' into patch-11

sobolevn commented Oct 7, 2022

Copy link

Copy Markdown

Member Author

It works now 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JulienPalard commented Oct 7, 2022

Copy link

Copy Markdown

Member

It works now tada

Yeah! It's better like that :)

Sorry for the inconvenience :(

sobolevn and arhadthedev reacted with heart emoji

All reactions

❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv merged commit 586cfb0 into python:main

Oct 7, 2022

bedevere-bot removed the awaiting core review label

Oct 7, 2022

carljm added a commit to carljm/cpython that referenced this pull request

Oct 8, 2022


          Merge branch 'main' into typewatch

27a4980

* main: (38 commits)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)
  pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)
  pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)
  pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)
  pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)
  pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)
  pythonGH-88968: Reject socket that is already used as a transport (python#98010)
  pythongh-96346: Use double caching for re._compile() (python#96347)
  pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)
  pythongh-96265: Fix some formatting in faq/design.rst (python#96924)
  pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)
  pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)
  pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)
  pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)
  pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)
  ...

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022


          pythongh-97956: Mention generate_global_objects.py in AC How-To (p…

8bc17aa

…ython#97957)

erlend-aasland pushed a commit to erlend-aasland/devguide that referenced this pull request

Sep 8, 2023


          python/cpython#97956: Mention generate_global_objects.py in `AC How…

5e68687

…-To` (python/cpython#97957)

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request

Sep 13, 2023


          python/cpython#97956: Mention generate_global_objects.py in `AC How…

5f6ac54

…-To` (python/cpython#97957)

erlend-aasland pushed a commit to python/devguide that referenced this pull request

Sep 26, 2023


          python/cpython#97956: Mention generate_global_objects.py in `AC How…

e630cce

…-To` (python/cpython#97957)

Reviewers

larryhastings

larryhastings left review comments

+1 more reviewer

blockchainGuru1018

blockchainGuru1018 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sobolevn commented Oct 6, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn commented Oct 6, 2022

Uh oh!

sobolevn commented Oct 6, 2022

Uh oh!

larryhastings left a comment

Choose a reason for hiding this comment

Uh oh!

larryhastings Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

larryhastings Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

sobolevn Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sobolevn commented Oct 6, 2022

Uh oh!

JulienPalard commented Oct 7, 2022

Uh oh!

sobolevn commented Oct 7, 2022

Uh oh!

JulienPalard commented Oct 7, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sobolevn commented Oct 6, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

sobolevn Oct 6, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.