GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||
GeezerVison is showing github.com — gh-91485: Doc: Using Python syntax to document builtin Python functions. by JulienPalard · Pull Request #96579 · python/cpython Conversation
|
|
I don't like: for an acute reader it scream "the default empty list is reused!", I have to change this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Antoine Rozo <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Biggest comment is on map().
A
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| .. function:: map(function, *iterables) | ||
|
|
||
| Return an iterator that applies *function* to every item of *iterable*, | ||
| yielding the results. If additional *iterable* arguments are passed, | ||
| Return an iterator that applies *function* to every item of *iterables*, | ||
| yielding the results. If additional *iterables* arguments are passed, |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I don't think the new wording is true, e.g.:
>>> from operator import add >>> for x in map(add, [1, 2, 3, 4, 5], [10, 20, 30, 40, 50]): >>> print(x) >>> 11 22 33 44 55
So it doesn't apply function to every item of iterables, but to every item of zip(*iterables).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
you're right, we have to rephrase it..
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
What about 7aca0e5 ? map(int) is not valid anyway.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
(I move the / in the following commit as iterable can't be given by name)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
0bf0db5 to
92a3bb0
Compare
|
@AA-Turner wow we were doing it in the same time, I just pushed my part, we'll be able to diff them to see if we agree :D |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this is good to merge personally.
A
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @JulienPalard, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-98276 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…unctions. (pythonGH-96579) (cherry picked from commit 3c4cbd1) Co-authored-by: Julien Palard <[email protected]>
…ns. (GH-96579) (cherry picked from commit 3c4cbd1) Co-authored-by: Julien Palard <[email protected]>
…ns. (GH-96579) (cherry picked from commit 3c4cbd1) Co-authored-by: Julien Palard <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.