GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100546: Remove incorrect positional-only marker from eval by hauntsaninja · Pull Request #100547 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Dec 27, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

All the arguments are positional-only.

The current status after #99476 seems to be to not use positional-only markers in documentation, hence I've simply removed it.

That said, there are still three other positional-only markers in this file). I asked for clarification in
#100546 (comment).
See also #98340

  • Issue: eval() documentation is wrong about keyword arguments #100546

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja
pythongh-100546: Remove incorrect positional-only marker from eval
5f05995 
All the arguments are positional-only.

The current status after python#99476 seems to be to not use positional-only
markers in documentation, hence I've simply removed it.

That said, there are still three other positional-only markers in this
file).  I asked for clarification in
python#100546 (comment).
See also python#98340
@bedevere-bot bedevere-bot mentioned this pull request Dec 27, 2022
eval() documentation is wrong about keyword arguments #100546
Closed
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Dec 27, 2022
@hauntsaninja hauntsaninja added needs backport to 3.11 only security fixes docs Documentation in the Doc dir awaiting core review skip news and removed docs Documentation in the Doc dir awaiting core review skip news labels Dec 27, 2022
@hauntsaninja

hauntsaninja commented Dec 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Only needs backporting to 3.11 because #96579 (and subsequent partial reverts) only got backported to 3.11 (seems not particularly intentionally, seems just because automatic backporting failed)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn
sobolevn approved these changes Dec 28, 2022
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Dec 30, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 30, 2022
@hauntsaninja
hauntsaninja merged commit 71159a8 into python:main Jan 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 1, 2023
@miss-islington

miss-islington commented Jan 1, 2023

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja
hauntsaninja deleted the fix-eval branch January 1, 2023 00:59
@bedevere-bot

bedevere-bot commented Jan 1, 2023

Copy link
Copy Markdown

GH-100654 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2023
@hauntsaninja @miss-islington
pythongh-100546: Remove incorrect positional-only marker from eval (p…
13173f8 
…ythonGH-100547)

All the arguments are positional-only.

The current status after pythonGH-99476 seems to be to not use positional-only
markers in documentation, hence I've simply removed it.
(cherry picked from commit 71159a8)

Co-authored-by: Shantanu <[email protected]>
miss-islington added a commit that referenced this pull request Jan 1, 2023
@miss-islington @hauntsaninja
gh-100546: Remove incorrect positional-only marker from eval (GH-100547)
7ed7127 
All the arguments are positional-only.

The current status after GH-99476 seems to be to not use positional-only
markers in documentation, hence I've simply removed it.
(cherry picked from commit 71159a8)

Co-authored-by: Shantanu <[email protected]>
@picnixz picnixz mentioned this pull request Mar 30, 2025
gh-131885: Updates docs to make max and min iterable param positional only #131868
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hauntsaninja @miss-islington @bedevere-bot @sobolevn @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.