GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97740: Fix bang in Sphinx C domain ref target syntax by CAM-Gerlach · Pull Request #97741 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Presently, ! doesn't work in Sphinx C domain reference target syntax in the docs due to an issue with c_allow_pre_v3 causing .disabled to be ignored. @AA-Turner developed a workaround to fix that, which I apply here in the conf.py.

  • Issue: Doc: Fix ! in C domain ref target syntax #97740

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CAM-Gerlach @AA-Turner
pythongh-97740: Fix bang in Sphinx C domain ref target syntax
edda9dd
Co-authored-by: Adam Turner <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Oct 2, 2022
@CAM-Gerlach
CAM-Gerlach requested review from AA-Turner and hugovk October 2, 2022 15:52
@CAM-Gerlach CAM-Gerlach added docs Documentation in the Doc dir skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 2, 2022
@CAM-Gerlach
CAM-Gerlach requested a review from ezio-melotti October 2, 2022 15:53
@CAM-Gerlach
CAM-Gerlach force-pushed the doc-fix-bang-c-domain branch from ce7fc52 to edda9dd Compare October 2, 2022 15:54
@CAM-Gerlach CAM-Gerlach added skip news and removed skip news labels Oct 2, 2022
@CAM-Gerlach
Add NEWS entry for C domain bang fix
1397a42
@CAM-Gerlach CAM-Gerlach removed the skip news label Oct 2, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 2, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
AA-Turner
AA-Turner approved these changes Oct 2, 2022
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 2, 2022
ezio-melotti
ezio-melotti approved these changes Oct 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 3, 2022
@ezio-melotti
ezio-melotti merged commit 9148c0d into python:main Oct 3, 2022
@miss-islington

miss-islington commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Oct 3, 2022
@bedevere-bot

bedevere-bot commented Oct 3, 2022

Copy link
Copy Markdown

GH-97748 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 3, 2022
@bedevere-bot

bedevere-bot commented Oct 3, 2022

Copy link
Copy Markdown

GH-97749 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 3, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2022
@CAM-Gerlach @miss-islington
pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python…
64cbbd7
…GH-97741)

* pythongh-97740: Fix bang in Sphinx C domain ref target syntax

Co-authored-by: Adam Turner <[email protected]>

* Add NEWS entry for C domain bang fix

Co-authored-by: Adam Turner <[email protected]>
(cherry picked from commit 9148c0d)

Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2022
@CAM-Gerlach @miss-islington
pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python…
48781a9
…GH-97741)

* pythongh-97740: Fix bang in Sphinx C domain ref target syntax

Co-authored-by: Adam Turner <[email protected]>

* Add NEWS entry for C domain bang fix

Co-authored-by: Adam Turner <[email protected]>
(cherry picked from commit 9148c0d)

Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request Oct 3, 2022
@miss-islington @CAM-Gerlach
gh-97740: Fix bang in Sphinx C domain ref target syntax (GH-97741)
a1711ef
* gh-97740: Fix bang in Sphinx C domain ref target syntax

Co-authored-by: Adam Turner <[email protected]>

* Add NEWS entry for C domain bang fix

Co-authored-by: Adam Turner <[email protected]>
(cherry picked from commit 9148c0d)

Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request Oct 3, 2022
@miss-islington @CAM-Gerlach
gh-97740: Fix bang in Sphinx C domain ref target syntax (GH-97741)
827f77e
* gh-97740: Fix bang in Sphinx C domain ref target syntax

Co-authored-by: Adam Turner <[email protected]>

* Add NEWS entry for C domain bang fix

Co-authored-by: Adam Turner <[email protected]>
(cherry picked from commit 9148c0d)

Co-authored-by: C.A.M. Gerlach <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 3, 2022
@carljm
Merge branch 'main' into dictwatch
e83abac
* main: (2069 commits)
  pythongh-96512: Move int_max_str_digits setting to PyConfig (python#96944)
  pythongh-94808: Coverage: Check picklablability of calliter (python#95923)
  pythongh-94808: Add test coverage for PyObject_HasAttrString (python#96627)
  pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (python#97765)
  Fix typos in `bltinmodule.c`. (pythonGH-97766)
  pythongh-94808: `_PyLineTable_StartsLine` was not used (pythonGH-96609)
  pythongh-97681: Remove Tools/demo/ directory (python#97682)
  Fix typo in unittest docs (python#97742)
  pythongh-97728: Argument Clinic: Fix uninitialized variable in the Py_UNICODE converter (pythonGH-97729)
  pythongh-95913: Fix PEP number in PEP 678 What's New ref label (python#97739)
  pythongh-95913: Copyedit/improve New Modules What's New section (python#97721)
  pythongh-97740: Fix bang in Sphinx C domain ref target syntax (python#97741)
  pythongh-96819: multiprocessing.resource_tracker: check if length of pipe write <= 512 (python#96890)
  pythongh-97706: multiprocessing tests: Delete unused variable `rand` (python#97707)
  pythonGH-85447: Clarify docs about awaiting future multiple times (python#97738)
  [docs] Update logging cookbook with recipe for using a logger like an output… (pythonGH-97730)
  pythongh-97607: Fix content parsing in the impl-detail reST directive (python#97652)
  pythongh-95975: Move except/*/finally ref labels to more precise locations (python#95976)
  pythongh-97591: In `Exception.__setstate__()` acquire strong references before calling `tp_hash` slot (python#97700)
  pythongh-95588: Drop the safety claim from `ast.literal_eval` docs. (python#95919)
  ...
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 21, 2022
gh-96073: fix backticks in NEWS entry #98056
Merged
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @CAM-Gerlach @pablogsal
gh-97740: Fix bang in Sphinx C domain ref target syntax (GH-97741)
10818aa
* gh-97740: Fix bang in Sphinx C domain ref target syntax

Co-authored-by: Adam Turner <[email protected]>

* Add NEWS entry for C domain bang fix

Co-authored-by: Adam Turner <[email protected]>
(cherry picked from commit 9148c0d)

Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@CAM-Gerlach @miss-islington @bedevere-bot @AA-Turner @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.