GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97983: Revert "Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase" by arhadthedev · Pull Request #98015 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Oct 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR reverts gh-93369 and gh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods.

The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first.

I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits.

Affected issue: gh-93357. First reported in #97940 (comment).

  • Issue: A bunch of CI failures on main branch #97983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
arhadthedev added 2 commits October 7, 2022 07:58
@arhadthedev
Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, p…
3713915 
…art 2 (python#97896)"

This reverts commit 09aea94.
@arhadthedev
Revert "pythongh-93357: Start porting asyncio server test cases to Is…
c17e930 
…olatedAsyncioTestCase (python#93369)"

This reverts commit ce8fc18.
@arhadthedev
arhadthedev requested review from 1st1, asvetlov and gvanrossum as code owners October 7, 2022 05:23
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 7, 2022
@arhadthedev

arhadthedev commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

For further debugging, here are some failures in question:

  • https://github.com/python/cpython/actions/runs/3201328217/jobs/5229183071
  • https://buildbot.python.org/all/#/builders/725/builds/2739
  • https://github.com/python/cpython/actions/runs/3193117202/jobs/5211355731
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 7, 2022
Replace use of test.test_asyncio.utils.TestCase with unittest.IsolatedAsyncioTestCase #93357
Closed
A bunch of CI failures on main branch #97983
Closed
@sobolevn sobolevn added the skip news label Oct 7, 2022
gvanrossum
gvanrossum approved these changes Oct 7, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll merge right away.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 7, 2022
@gvanrossum
gvanrossum merged commit f99bb20 into python:main Oct 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2022
@arhadthedev
arhadthedev deleted the utilsTestCase-teststreams-rollback branch October 7, 2022 15:26
@arhadthedev arhadthedev mentioned this pull request Oct 9, 2022
Fix a bunch of failing tests arhadthedev/cpython#11
Open
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@arhadthedev @mpage
pythongh-97983: Revert "Lay the foundation for further work in asynci…
e75ada1 
…o.test_streams: port server cases to IsolatedAsyncioTestCase" (python#98015)

This PR reverts pythongh-93369 and pythongh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods.

The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first.

I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits.

Affected issue: pythongh-93357.
First reported in python#97940 (comment).

* Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)"

This reverts commit 09aea94.

* Revert "pythongh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (python#93369)"

This reverts commit ce8fc18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@arhadthedev @gvanrossum @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.