GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 by arhadthedev · Pull Request #97896 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Oct 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR is a follow-up to gh-93369 to fix broken Ubuntu SSL tests with OpenSSL and Ubuntu SSL tests with OpenSSL (3.0.5) tests.

The break is caused by async-isation of a few tests in class StreamTests2(test_utils.TestCase) not designed for this. Since they happen to be grouped in the end of a file, it's easier to group them under an unplanned class NewStreamTests2(unittest.IsolatedAsyncioTestCase) and make three in-between tests async too rather that partially roll the changes back.

Thanks to @kumaraditya303 for noticing the issue.

Closes gh-97894.

  • Issue: Replace use of test.test_asyncio.utils.TestCase with unittest.IsolatedAsyncioTestCase #93357

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@arhadthedev
Port test cases to IsolatedAsyncioTestCase, part 2
79505df
@arhadthedev
arhadthedev requested review from 1st1, asvetlov and gvanrossum as code owners October 5, 2022 05:54
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 5, 2022
@kumaraditya303 kumaraditya303 added topic-asyncio skip news labels Oct 5, 2022
@arhadthedev arhadthedev mentioned this pull request Oct 5, 2022
gh-93357: Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase #93369
Merged
@arhadthedev
arhadthedev marked this pull request as draft October 5, 2022 06:20
arhadthedev added 2 commits October 5, 2022 10:22
@arhadthedev
Remove self.loop.set_exception_handler
a46c222
@arhadthedev
Another fix
ee7e966
@arhadthedev

arhadthedev commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

Retriggering the stuck checks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev arhadthedev closed this Oct 5, 2022
@arhadthedev arhadthedev reopened this Oct 5, 2022
arhadthedev added 3 commits October 5, 2022 10:57
@arhadthedev
Fix a misuse of async with
bc21d76
@arhadthedev
Remove more asyncio.open_connection()
87e841c
@arhadthedev
Return an assignment to data
7b8caca
@sobolevn

sobolevn commented Oct 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Please, feel free to ping me when ready. I will run buildbot tests for you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev

arhadthedev commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

@sobolevn Pinging since the tests are done.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev
arhadthedev marked this pull request as ready for review October 5, 2022 08:49
@sobolevn sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 5, 2022
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 7b8caca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 5, 2022
@arhadthedev arhadthedev mentioned this pull request Oct 5, 2022
test_asyncio failures in the "Ubuntu with SSL" tests #97894
Closed
gvanrossum
gvanrossum approved these changes Oct 5, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good. I'll merge. Thanks for the quick fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@gvanrossum
gvanrossum merged commit 09aea94 into python:main Oct 5, 2022
@arhadthedev
arhadthedev deleted the teststreams-utilsTestCase-servers-2 branch October 5, 2022 14:39
@bedevere-bot bedevere-bot removed the awaiting review label Oct 5, 2022
@arhadthedev arhadthedev mentioned this pull request Oct 6, 2022
Replace use of test.test_asyncio.utils.TestCase with unittest.IsolatedAsyncioTestCase #93357
Closed
21 tasks
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
4bb5d9d
* main: (66 commits)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)
  pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)
  pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)
  pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)
  pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)
  pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)
  pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)
  pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)
  pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826)
  Add re.VERBOSE flag documentation example (python#97678)
  ...
arhadthedev added a commit to arhadthedev/cpython that referenced this pull request Oct 7, 2022
@arhadthedev
Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, p…
3713915
…art 2 (python#97896)"

This reverts commit 09aea94.
@arhadthedev arhadthedev mentioned this pull request Oct 7, 2022
gh-97983: Revert "Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase" #98015
Merged
gvanrossum pushed a commit that referenced this pull request Oct 7, 2022
@arhadthedev
gh-97983: Revert "Lay the foundation for further work in asyncio.test…
f99bb20
…_streams: port server cases to IsolatedAsyncioTestCase" (#98015)

This PR reverts gh-93369 and gh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods.

The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first.

I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits.

Affected issue: gh-93357.
First reported in #97940 (comment).

* Revert "gh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (#97896)"

This reverts commit 09aea94.

* Revert "gh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (#93369)"

This reverts commit ce8fc18.
@arhadthedev arhadthedev mentioned this pull request Oct 9, 2022
Fix a bunch of failing tests arhadthedev/cpython#11
Open
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@arhadthedev @mpage
pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (p…
2d20cf5
…ython#97896)

This fixes the buildbots.
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@arhadthedev @mpage
pythongh-97983: Revert "Lay the foundation for further work in asynci…
e75ada1
…o.test_streams: port server cases to IsolatedAsyncioTestCase" (python#98015)

This PR reverts pythongh-93369 and pythongh-97896 because they've made asyncio tests unstable. After these PRs were merged, random GitHub action jobs of random commits started to fail unrelated tests and test framework methods.

The reverting is necessary because such shrapnel failures are a symptom of some underlying bug that must be found and fixed first.

I had a hope that it's a server overload because we already have extremely rare disc access errors. However, one and a half day passed, and the failures continue to emerge both in PRs and commits.

Affected issue: pythongh-93357.
First reported in python#97940 (comment).

* Revert "pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)"

This reverts commit 09aea94.

* Revert "pythongh-93357: Start porting asyncio server test cases to IsolatedAsyncioTestCase (python#93369)"

This reverts commit ce8fc18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_asyncio failures in the "Ubuntu with SSL" tests

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@arhadthedev @sobolevn @bedevere-bot @gvanrossum @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.