GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-98703: Add tests for closing `_ProactorSocketTransport` with proactor event loop (GH-98730) by miss-islington · Pull Request #98755 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 27, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya [email protected]

  • Issue: Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows #98703

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kumaraditya303 @miss-islington
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
0193292
… proactor event loop (pythonGH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners October 27, 2022 03:07
@bedevere-bot bedevere-bot mentioned this pull request Oct 27, 2022
gh-98703: add tests for closing _ProactorSocketTransport with proactor event loop #98730
Merged
@bedevere-bot bedevere-bot added skip news awaiting review tests Tests in the Lib/test dir labels Oct 27, 2022
Fidget-Spinner
Fidget-Spinner approved these changes Oct 27, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 27, 2022
@miss-islington
miss-islington merged commit 8e475ad into python:3.11 Oct 27, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 27, 2022
@miss-islington
miss-islington deleted the backport-96ae80f-3.11 branch October 27, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @Fidget-Spinner @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.