GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98703: add tests for closing `_ProactorSocketTransport` with proactor event loop by kumaraditya303 · Pull Request #98730 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Oct 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Consistent test failures in test test_asyncio.test_streams.test_drain_raises on Windows #98703

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 26, 2022
@kumaraditya303 kumaraditya303 added topic-asyncio skip issue skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 26, 2022
@kumaraditya303 kumaraditya303 changed the title add tests for closing asyncio.StreamWriter with proactor event loop add tests for closing _ProactorSocketTransport with proactor event loop Oct 26, 2022
@kumaraditya303
add test for proactor event loop
51ffb5d
@kumaraditya303
kumaraditya303 force-pushed the proactor-test branch from c8ec7e6 to 51ffb5d Compare October 26, 2022 16:19
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 26, 2022
gh-98703: Fix asyncio proactor_events calling _call_connection_lost multiple times #98704
Merged
@Fidget-Spinner Fidget-Spinner changed the title add tests for closing _ProactorSocketTransport with proactor event loop gh-98703: add tests for closing _ProactorSocketTransport with proactor event loop Oct 26, 2022
@Fidget-Spinner Fidget-Spinner removed the skip issue label Oct 26, 2022
@Fidget-Spinner

Fidget-Spinner commented Oct 26, 2022

Copy link
Copy Markdown
Member

Skip news because it shares the same news item as #98704.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Merge branch 'main' into proactor-test
66497c5
@kumaraditya303
kumaraditya303 marked this pull request as ready for review October 27, 2022 02:50
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov and gvanrossum as code owners October 27, 2022 02:50
Fidget-Spinner
Fidget-Spinner approved these changes Oct 27, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 27, 2022
@Fidget-Spinner

Fidget-Spinner commented Oct 27, 2022

Copy link
Copy Markdown
Member

These are great tests. It seems that they failed on every platform prior to the fix :)!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit 96ae80f into python:main Oct 27, 2022
@miss-islington

miss-islington commented Oct 27, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 27, 2022
@bedevere-bot

bedevere-bot commented Oct 27, 2022

Copy link
Copy Markdown

GH-98755 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 27, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2022
@kumaraditya303 @miss-islington
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
6869604 
… proactor event loop (pythonGH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 27, 2022

Copy link
Copy Markdown

GH-98756 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 27, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2022
@kumaraditya303 @miss-islington
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
0193292 
… proactor event loop (pythonGH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Oct 27, 2022
@miss-islington @kumaraditya303
gh-98703: Add tests for closing _ProactorSocketTransport with proac…
8e475ad 
…tor event loop (GH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Oct 27, 2022
@miss-islington @kumaraditya303
gh-98703: Add tests for closing _ProactorSocketTransport with proac…
9338e9a 
…tor event loop (GH-98730)

(cherry picked from commit 96ae80f)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303
kumaraditya303 deleted the proactor-test branch October 27, 2022 07:38
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Oct 28, 2022
@kumaraditya303 @gvanrossum
pythongh-98703: Add tests for closing _ProactorSocketTransport with…
c66cd30 
… proactor event loop (pythonGH-98730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @Fidget-Spinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.