GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81057: Move Globals in Core Code to _PyRuntimeState by ericsnowcurrently · Pull Request #99496 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 14, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the first of several PRs to consolidate non-object globals in core code.

  • Issue: [subinterpreters] Global C variables are a problem #81057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 14, 2022
@ericsnowcurrently
ericsnowcurrently requested review from lysnikolaou and pablogsal as code owners November 14, 2022 22:53
@bedevere-bot bedevere-bot added the awaiting core review label Nov 14, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 14, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
@ericsnowcurrently
ericsnowcurrently removed request for lysnikolaou and pablogsal November 14, 2022 22:54
ericsnowcurrently added 15 commits November 14, 2022 15:58
@ericsnowcurrently
Move the legacy config flag globals to the ignored list.
7c18aeb
@ericsnowcurrently
Move a safe static buffer to the ignored list.
dbe7219
@ericsnowcurrently
Move effectively-const globals initialized during init.
f45f960
@ericsnowcurrently
Move single-context globals to the ignored list.
acf1a9b
@ericsnowcurrently
Add a TODO comment about leaked memory.
72492eb
@ericsnowcurrently
Move more globals to the ignored list.
c908958
@ericsnowcurrently
Re-organize the ignored list a tiny bit.
5357ea4
@ericsnowcurrently
Move more globals to the ignored list.
6a3fb95
@ericsnowcurrently
Only generate the version & build info once.
efad4c3
@ericsnowcurrently
Tweak the ignored list.
3c97f38
@ericsnowcurrently
Move _Py_tracemalloc_config to _PyRuntimeState.
b9df429
@ericsnowcurrently
Adjust the whitelist.
a0a961e
@ericsnowcurrently
Move the Bigint freelist to _PyRuntimeState.
c7e4333
@ericsnowcurrently
Move the Bigint preallocated memory to _PyRuntimeState.
5c4fde4
@ericsnowcurrently
Move static_arg_parsers into _PyRuntimeState.
3d803e9
@ericsnowcurrently
ericsnowcurrently force-pushed the consolidate-core-globals branch from 144753e to 3d803e9 Compare November 14, 2022 23:00
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 14, 2022
@bedevere-bot

bedevere-bot commented Nov 14, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 3d803e9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 14, 2022
@ericsnowcurrently
ericsnowcurrently merged commit 3c57971 into python:main Nov 15, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 15, 2022
@ericsnowcurrently
ericsnowcurrently deleted the consolidate-core-globals branch November 15, 2022 16:45
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
@CuriousLearner
Merge branch 'main' into fix-issue21914
abd206e
* main: (8272 commits)
  Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)
  pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)
  pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)
  pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496)
  Post 3.12.0a2
  pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)
  pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)
  pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)
  pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)
  pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)
  pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)
  pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)
  pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)
  pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)
  pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)
  pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)
  pythongh-99300: Use Py_NewRef() in Doc/ directory  (python#99480)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)
  pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.