GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Skip 3.12-dev pending Greenlet support by hugovk · Pull Request #259 · python/pyperformance

Conversation

hugovk commented Jan 11, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

At the moment the 3.12-dev builds are failing, causing every build to show as failed.

It's failing because Greenlet doesn't yet support 3.12. The tracking issue is at python-greenlet/greenlet#323 and there's a PR at python-greenlet/greenlet#327 but it's not ready yet.

In the meantime, we can mark 3.12-dev as "experimental", so whilst the individual job still fails, it doesn't mark the whole build as failed.

Docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error

Also bump GitHub Actions, allow building feature branches, and we can fold the PyPy config into the main list. workflow_dispatch adds a button to the UI to be able to trigger new builds, occasionally useful.

Shall we also remove pypy3.7? The newest PyPy only supports 3.8 and 3.9:

https://www.pypy.org/posts/2022/12/pypy-v7311-release.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This comment was marked as outdated.

hugovk marked this pull request as draft

January 12, 2023 07:31

hugovk force-pushed the ci-update branch from 80d9526 to cf410a7 Compare

January 15, 2023 15:48

hugovk changed the title ~~Allow 3.12-dev to fail pending Greenlet support~~ Skip 3.12-dev pending Greenlet support

Jan 15, 2023

hugovk commented Jan 15, 2023

Copy link

Copy Markdown

Member Author

Need to research more about how continue-on-error works, for now I think it's fine to remove the failing 3.12-dev from the matrix until python-greenlet/greenlet#323 is resolved.

I also removed unsupported pypy3.7.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk marked this pull request as ready for review

January 15, 2023 16:05

hugovk added 4 commits

January 15, 2023 18:18


          Refactor: PyPy into matrix with others on ubuntu-latest

be5fdf7


          Bump GitHub Actions

8e43134


          Skip 3.12-dev pending Greenlet support

fcaf941


          Remove unsupported pypy3.7

23663df

hugovk force-pushed the ci-update branch from cf410a7 to 23663df Compare

January 15, 2023 16:19

AlexWaygood mentioned this pull request

Feb 5, 2023

Tests fail with Python 3.12 #263

Closed

hugovk mentioned this pull request

Feb 5, 2023

Skip tests failing on Python 3.12 pending greenlet support #264

Closed

hugovk commented Feb 5, 2023

Copy link

Copy Markdown

Member Author

Please see PR #264 to replace this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pradyunsg reviewed

Feb 5, 2023

View reviewed changes

Comment thread

.github/workflows/main.yml

Comment on lines +21 to +22

		# Skip 3.12-dev, pending https://github.com/python-greenlet/greenlet/issues/323
		python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]

pradyunsg Feb 5, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures correctly, we can achieve what we want to with something like:

    continue-on-error: ${{ matrix.failure-allowed }}
    strategy:
      fail-fast: false
      matrix:
        # Test all supported versions on Ubuntu:
        os: [ubuntu-latest]
        python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]
        failure-allowed: [false]
        include:
          # Also test macOS and Windows:
          - os: macos-latest
            python: "3.10"
            failure-allowed: false
          - os: windows-latest
            python: "3.10"
            failure-allowed: false
          # Also test in-development version (allowing failures):
          - os: ubuntu-latest
            python: "3.12-dev"
            failure-allowed: true

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pradyunsg Feb 5, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure-allowed is a verb/phrase that we can change as we wish to communicate things via the variable name. The example from GitHub used experimental.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk Feb 5, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did try something along those lines, but wasn't successful.

Although I think #264 is a better approach? Then we'll at least see if the non-greenlet tests fail for 3.12. And when greenlet installs for 3.12, it'll start testing those too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pradyunsg Feb 5, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at your force-pushed events' diffs, I don't see continue-on-error: ${{ matrix.failure-allowed }} being added at any point at the job.<id> level; which might be why they didn't work?

Regardless, they're both valid approaches to solving the problem so it's not a big deal which one we go with. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

hugovk Feb 5, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried it in another branch:

  test:
    runs-on: ${{ matrix.os }}
    name: ${{ matrix.os }} - ${{ matrix.python }}
    continue-on-error: ${{ matrix.experimental }}
    strategy:
      fail-fast: false
      matrix:
        # Test all supported versions on Ubuntu:
        os: [ubuntu-latest]
        python: [pypy3.7, pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]
        experimental: [false]
        include:
          # Also test macOS and Windows:
          - os: macos-latest
            python: "3.10"
            experimental: false
          - os: windows-latest
            python: "3.10"
            experimental: false
          # Allow 3.12-dev to fail pending https://github.com/python-greenlet/greenlet/issues/323
          - os: ubuntu-latest
            python: 3.12-dev
            experimental: true

Very similar to your snippet:

But still failed a PR: hugovk#3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pradyunsg Feb 5, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Thanks for clarifying! ^.^

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk reacted with thumbs up emoji

All reactions

👍 1 reaction

hugovk commented Apr 20, 2023

Copy link

Copy Markdown

Member Author

Closed in favour of #274 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk closed this

Apr 20, 2023

hugovk deleted the ci-update branch

April 20, 2023 22:06

Reviewers

pradyunsg

pradyunsg left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hugovk commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

hugovk commented Jan 15, 2023

Uh oh!

hugovk commented Feb 5, 2023

Uh oh!

pradyunsg Feb 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pradyunsg Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

hugovk Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

pradyunsg Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

hugovk Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

pradyunsg Feb 5, 2023

Choose a reason for hiding this comment

Uh oh!

hugovk commented Apr 20, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hugovk commented Jan 11, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

pradyunsg Feb 5, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.