GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip tests failing on Python 3.12 pending greenlet support by hugovk · Pull Request #264 · python/pyperformance

Conversation

@hugovk

@hugovk hugovk commented Feb 5, 2023

Copy link
Copy Markdown
Member

Fixes #263.

Alternative to and closes #259.

At the moment the 3.12-dev builds are failing, causing every build to show as failed.

It's failing because greenlet doesn't yet support 3.12. The tracking issue is at python-greenlet/greenlet#323 and there's a PR at python-greenlet/greenlet#327 but it's not ready yet.

In the meantime, let's skip the two tests when greenlet isn't available.

Also bump GitHub Actions, allow building feature branches, and we can fold the PyPy config into the main list. workflow_dispatch adds a button to the UI to be able to trigger new builds, occasionally useful.

And remove pypy3.7, the newest PyPy only supports 3.8 and 3.9:

  • https://www.pypy.org/posts/2022/12/pypy-v7311-release.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mdboom reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
hugovk added 4 commits February 5, 2023 11:46
@hugovk
Skip tests failing on Python 3.12 pending greenlet support
f6dd9f4
@hugovk
Bump GitHub Actions
35d0a52
@hugovk
Refactor: PyPy into matrix with others on ubuntu-latest
2d4dfb7
@hugovk
Remove unsupported pypy3.7
c711f33
This was referenced Feb 5, 2023
Tests fail with Python 3.12 #263
Closed
Skip 3.12-dev pending Greenlet support #259
Closed
pradyunsg
pradyunsg reviewed Feb 5, 2023
View reviewed changes
Comment thread .github/workflows/main.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Apr 20, 2023

Copy link
Copy Markdown
Member Author

Closed in favour of #274 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk closed this Apr 20, 2023
@hugovk
hugovk deleted the skip-greenlet branch April 20, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pradyunsg pradyunsg pradyunsg left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests fail with Python 3.12

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @pradyunsg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.