Description

gvanrossum

opened on Feb 5, 2023

Issue body actions

Whenever I push something to a PR in the cpython main branch (3.12) I get an email from this repo telling me that the 3.12 run failed. Is there a way we can fix it? Here's a link to the failing run: https://github.com/python/pyperformance/actions/runs/4094033809/jobs/7059879010

I'd rather not just disable running with 3.12 (that would presumably take away some useful signal) but maybe we can fix or suppress the failing tests?

Activity

1. AlexWaygood commented on Feb 5, 2023

   

   AlexWaygood

   on Feb 5, 2023

   Member

   More actions

   I believe this PR by @hugovk would mean that the tests would still run, but wouldn't be reported as "failures" for now:

   • Skip 3.12-dev pending Greenlet support #259
2. gvanrossum commented on Feb 5, 2023

   

   gvanrossum

   on Feb 5, 2023

   MemberAuthor

   More actions

   Yeah, that just disables 3.12 altogether, right? Isn't there a way to only disable those tests that depend on greenlet?
3. gvanrossum commented on Feb 5, 2023

   

   gvanrossum

   on Feb 5, 2023

   MemberAuthor

   More actions

   IIRC in the past we resolved a similar thing (for a different dependency) by changing the requirements.txt file to reference a specific PR (via some notation I've forgotten that lets you depend on a git repo/branch).
4. hugovk commented on Feb 5, 2023

   

   hugovk

   on Feb 5, 2023

   Member

   More actions

   Yeah, that just disables 3.12 altogether, right?

   Yes, the original intent of #259 was to run on 3.12, and if 3.12 fails, then don't fail the whole build. But I couldn't find the right continue-on-error incantation, so instead it disables the whole 3.12 job.

   Isn't there a way to only disable those tests that depend on greenlet?

   Yes, we can skip them when greelet isn't available. Please see PR #264.
5. gvanrossum commented on Feb 5, 2023

   

   gvanrossum

   on Feb 5, 2023

   MemberAuthor

   More actions

   Yeah, #264 feels better. I hesitate to approve it, since I am not familiar with this code base (nor with the sutbleties of GitHub workflows) but maybe @mdboom can take a quick look.
6. corona10

   added a commit that references this issue on Apr 19, 2023

   pythongh-263: Run Python 3.12 task as the experimental task

   63256c1
7. corona10 commented on Apr 19, 2023

   

   corona10

   on Apr 19, 2023

   Member

   More actions

   @gvanrossum I proposed another PR that does not touch pyperformance code directly but managing by GHA meta data.

   PR: #274 (Expect as working correctly after the PR is merged)
   Sample: corona10#1 (comment)
8. corona10 commented on Apr 19, 2023

   

   corona10

   on Apr 19, 2023

   Member

   More actions

   Ah https://github.com/python/pyperformance/pull/259/files#r1096738419 looks similar approach but I didn't notice it
9. hugovk commented on Apr 19, 2023

   

   hugovk

   on Apr 19, 2023

   Member

   More actions

   Looks like the key difference between those, you have continue-on-error: ${{ matrix.experimental }} at the job level, I had it at the step level. Nice work!
10. corona10

    added 3 commits that reference this issue on Apr 19, 2023

    gh-263: Run Python 3.12 task as the experimental task (#274)

    fe07325

    pythongh-263: Remove detection bit for a while

    a0be744

    gh-263: Remove detection bit for a while (#276)

    ca27f73
11. corona10 commented on Apr 20, 2023

    

    corona10

    on Apr 20, 2023

    Member

    More actions

    Close this issue :) If the issue is needed to be reopened, feel free to open the issue again.

    Reacted by Hugo van Kemenade
12. corona10

    closed this as completedon Apr 20, 2023

Issue actions