GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add a YAML-parsing benchmark by mdboom · Pull Request #342 · python/pyperformance

Conversation

mdboom commented Jun 14, 2024

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mdboom added 2 commits

June 14, 2024 14:16


          Add a YAML-parsing benchmark

379c047


          Fix description

e3c590f

mdboom requested a review from ericsnowcurrently

June 21, 2024 14:29

ericsnowcurrently approved these changes

Jun 21, 2024

View reviewed changes

ericsnowcurrently left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've left a couple of very minor comments that I'll leave to you to resolve/ignore before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

pyperformance/data-files/benchmarks/bm_yaml/run_benchmark.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

pyperformance/data-files/benchmarks/bm_yaml/run_benchmark.py

Comment on lines +8 to +9

		This explicitly tests the pure Python implementation in pyyaml, not its C
		extension.

ericsnowcurrently Jun 21, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful comment. It may be worth moving it next to the line where we take this action. I'm guessing that's the Loader=yaml.Loader bit on line 70.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

pyperformance/data-files/benchmarks/bm_yaml/run_benchmark.py

Comment on lines +23 to +61

		DICT = {
		'ads_flags': 0,
		'age': 18,
		'bulletin_count': 0,
		'comment_count': 0,
		'country': 'BR',
		'encrypted_id': 'G9urXXAJwjE',
		'favorite_count': 9,
		'first_name': '',
		'flags': 412317970704,
		'friend_count': 0,
		'gender': 'm',
		'gender_for_display': 'Male',
		'id': 302935349,
		'is_custom_profile_icon': 0,
		'last_name': '',
		'locale_preference': 'pt_BR',
		'member': 0,
		'tags': ['a', 'b', 'c', 'd', 'e', 'f', 'g'],
		'profile_foo_id': 827119638,
		'secure_encrypted_id': 'Z_xxx2dYx3t4YAdnmfgyKw',
		'session_number': 2,
		'signup_id': '201-19225-223',
		'status': 'A',
		'theme': 1,
		'time_created': 1225237014,
		'time_updated': 1233134493,
		'unread_message_count': 0,
		'user_group': '0',
		'username': 'collinwinter',
		'play_count': 9,
		'view_count': 7,
		'zip': ''}

		TUPLE = (
		[265867233, 265868503, 265252341, 265243910, 265879514,
		266219766, 266021701, 265843726, 265592821, 265246784,
		265853180, 45526486, 265463699, 265848143, 265863062,
		265392591, 265877490, 265823665, 265828884, 265753032], 60)

ericsnowcurrently Jun 21, 2024

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth it to also/instead use some real-world data, like we do for bm_tomli_loads?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mdboom and others added 2 commits

June 24, 2024 15:11


          Update pyperformance/data-files/benchmarks/bm_yaml/run_benchmark.py

b267db0

Co-authored-by: Eric Snow <[email protected]>


          Merge branch 'main' into add-yaml-benchmark

e322410

hugovk commented Dec 17, 2025

Copy link

Copy Markdown

Member

Let's merge this.

@mdboom Make the suggested changes if you like, otherwise let's just merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mdboom merged commit bb8495c into python:main

Dec 17, 2025

19 checks passed

Uh oh!

There was an error while loading. Please reload this page.

maurycy added a commit to maurycy/pyperformance that referenced this pull request

Jan 2, 2026


          Merge branch 'main' into uv

1e4df75

* main:
  Bump mypy from 1.19 to 1.19.1 (python#448)
  Add a YAML-parsing benchmark (python#342)
  Add FastAPI HTTP request benchmark (python#440)
  Add option for rigorous in benchmark.conf.sample (python#446)
  Do not `venv.ensure_reqs` twice (python#432)
  Bump mypy from 1.18.2 to 1.19.0 (python#442)
  Bump actions/checkout from 5 to 6 in the actions group (python#441)
  Add example scripts to run pyperformance on a generic host (python#436)
  Prepare for 1.13.0 release (python#435)
  Reenable xdsl (python#433)
  Bump actions/setup-python from 5 to 6 (python#429)
  Group Dependabot updates for GitHub Actions into single PR (python#431)
  Bump actions/checkout from 4 to 5 (python#430)

Reviewers

ericsnowcurrently

ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.