GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add option for rigorous in benchmark.conf.sample by Fidget-Spinner · Pull Request #446 · python/pyperformance

Conversation

Fidget-Spinner commented Dec 7, 2025

Copy link

Copy Markdown

Member

Closes #445

No tests because there are no current tests for the option configurations in the current file :(.

I have manually verified that it works on my system.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add option for rigorous in benchmark.conf.sample

5a96041

corona10 approved these changes

Dec 8, 2025

View reviewed changes

corona10 left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

The test failure does not looks like reated to this PR.
But need to check

pyperformance/pyperformance/tests/test_commands.py

Lines 147 to 167 in 0ffe825

	def test_run_and_show(self):
	filename = self.resolve_tmp("bench.json")

	# -b all: check that all benchmark work
	#
	# --debug-single-value: benchmark results don't matter, we only
	# check that running benchmarks don't fail.
	# XXX Capture and check the output.
	self.run_pyperformance(
	"run",
	"-b",
	"all",
	"--debug-single-value",
	"-o",
	filename,
	capture=None,
	)

	# Display slowest benchmarks
	# XXX Capture and check the output.
	self.run_module("pyperf", "slowest", filename)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Fidget-Spinner merged commit 4494463 into main

Dec 8, 2025

70 of 72 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Fidget-Spinner deleted the rigorous-option branch

December 8, 2025 15:27

maurycy added a commit to maurycy/pyperformance that referenced this pull request

Jan 2, 2026


          Merge branch 'main' into uv

1e4df75

* main:
  Bump mypy from 1.19 to 1.19.1 (python#448)
  Add a YAML-parsing benchmark (python#342)
  Add FastAPI HTTP request benchmark (python#440)
  Add option for rigorous in benchmark.conf.sample (python#446)
  Do not `venv.ensure_reqs` twice (python#432)
  Bump mypy from 1.18.2 to 1.19.0 (python#442)
  Bump actions/checkout from 5 to 6 in the actions group (python#441)
  Add example scripts to run pyperformance on a generic host (python#436)
  Prepare for 1.13.0 release (python#435)
  Reenable xdsl (python#433)
  Bump actions/setup-python from 5 to 6 (python#429)
  Group Dependabot updates for GitHub Actions into single PR (python#431)
  Bump actions/checkout from 4 to 5 (python#430)

Reviewers

corona10

corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

compile_all config file does not respect rigorous option

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.