Description

hugovk

opened on Mar 18, 2023

Issue body actions

1. Using the new dark theme (Dark theme #44) in mobile layout: https://docs.python.org/dev/
2. Search for something (e.g. "turtle")

3. Click a result

Actual result: "Hide Search Matches" is shown subscript to the right of the search box

Expected result: It's either shown more neatly, or, like desktop view, isn't shown at all:

cc @septatrix

Reacted by Maciej Olko

Activity

1. hugovk

   added

   bug

   on Mar 18, 2023
2. septatrix commented on Mar 21, 2023

   

   septatrix

   on Mar 21, 2023

   Contributor

   More actions

   Okay I found the culprit/fix to restore the previous behaviour (not shown at all). Do we want that or would it actually be desirable to show it?
3. septatrix commented on Mar 21, 2023

   

   septatrix

   on Mar 21, 2023

   Contributor

   More actions

   Given that it is only ever added to either the mobile UI or the desktop UI I feel like it is probably less confusing to suppress it again, aye?
4. rik commented on Mar 21, 2023

   

   rik

   on Mar 21, 2023

   More actions

   Besides the UI glitch, I was actually glad to discover this "bug" as I'm not fond of matches being highlighted.

   I wish it was available on the wide screen UI too.
5. septatrix commented on Mar 22, 2023

   

   septatrix

   on Mar 22, 2023

   Contributor

   More actions

   The problem is that the toggle is only added to the #searchbox element of which there can be only one. So either it would not be visible in one of the two layouts or we would have to do some pretty crazy CSS shenanigans to reuse the same search box in the desktop and mobile layout.
6. hugovk commented on Mar 25, 2023

   

   hugovk

   on Mar 25, 2023

   MemberAuthor

   More actions

   I wish it was available on the wide screen UI too.

   You can press esc to remove the highlights.

   ---

   Given that it is only ever added to either the mobile UI or the desktop UI I feel like it is probably less confusing to suppress it again, aye?

   Yeah, no strong opinion from me, if in doubt let's go for the previous behaviour. Thank you!

   Reacted by Anthony Ricaud
7. hugovk commented on Apr 11, 2023

   

   hugovk

   on Apr 11, 2023

   MemberAuthor

   More actions

   @septatrix Would you be able to restore the previous behaviour? For me, this is the only one of the reported issues I'd like fixed before deploying this more widely. And I've heard lots of good feedback about the dark theme!
8. septatrix

   added a commit that references this issue on Apr 12, 2023

   Remove searchbox id from form (fixes python#117)

   This issue will close once commit 14e362f is merged into the 'master' branch.

   14e362f
9. septatrix commented on Apr 12, 2023

   

   septatrix

   on Apr 12, 2023

   Contributor

   More actions

   @septatrix Would you be able to restore the previous behaviour? For me, this is the only one of the reported issues I'd like fixed before deploying this more widely. And I've heard lots of good feedback about the dark theme!

   Done, #124 restores the previous behaviour

   Reacted by Hugo van Kemenade
10. hugovk

    closed this as completedin #124on Apr 14, 2023

Issue actions