GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — support discrete system as input for FRD by bnavigator · Pull Request #568 · python-control/python-control

Conversation

@bnavigator

@bnavigator bnavigator commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Triggered by #566 and #523, it was revealed that the evaluation of the sys parameter does not take into account discrete time systems.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnavigator
support discrete system as input for FRD
fd80fc8
@bnavigator bnavigator mentioned this pull request Mar 12, 2021
new method keyword in stability_margins and auto-fallback back to FRD .. #566
Merged
@bnavigator

bnavigator commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

... needs unit tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Mar 12, 2021

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.04%) to 88.821% when pulling fd80fc8 on bnavigator:discretesys2frd into 92de12d on python-control:master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sawyerbfuller
sawyerbfuller approved these changes Mar 12, 2021
View reviewed changes

@sawyerbfuller sawyerbfuller left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One remark: FRD.__call__ only works with purely imaginary arguments of the form omega*1j, which I think is still what we want, right? The alternative is if an FRD system derived from a discrete time system that z must be on the unit circle. I think I favor the former but I am not positive that is the "right" way or not.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnavigator reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sawyerbfuller
sawyerbfuller merged commit 0f951e1 into python-control:master Mar 12, 2021
sawyerbfuller added a commit to sawyerbfuller/python-control that referenced this pull request Mar 12, 2021
@sawyerbfuller
incorporated fix enabled by github python-control#568
2b82eef
@bnavigator

bnavigator commented Mar 12, 2021

Copy link
Copy Markdown
Contributor Author

I also favor the current. Otherwise you would have to keep track from which kind you created the FRD system.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
@bnavigator
bnavigator deleted the discretesys2frd branch February 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bnavigator @coveralls @sawyerbfuller @murrayrm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.