GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feat: cover all audit events by nejch · Pull Request #1363 · python-gitlab/python-gitlab

Conversation

@nejch

@nejch nejch commented Mar 7, 2021

Copy link
Copy Markdown
Member

This adds group audit events, moves all audit events into one module and makes the class naming consistent.

Closes #1107, closes #948.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
max-wittig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
nejch added 4 commits March 7, 2021 12:23
@nejch
refactor(objects): move instance audit events where they belong
48ba88f
@nejch
fix(objects): add single get endpoint for instance audit events
c3f0a6f
@nejch
chore: import audit events in objects
35a190c
@nejch
test(objects): add unit test for instance audit events
84e3247
@nejch
nejch force-pushed the feat/all-audit-events branch from 6101513 to 23e37c5 Compare March 7, 2021 12:12
@codecov-io

codecov-io commented Mar 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1363 (23e37c5) into master (48fc907) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   79.92%   80.01%   +0.08%     
==========================================
  Files          73       73              
  Lines        4010     4028      +18     
==========================================
+ Hits         3205     3223      +18     
  Misses        805      805
Flag Coverage Δ
unit 80.01% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/events.py 100.00% <ø> (ø)
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/audit_events.py 100.00% <100.00%> (ø)
gitlab/v4/objects/groups.py 76.40% <100.00%> (+0.26%) ⬆️
gitlab/v4/objects/projects.py 73.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fc907...23e37c5. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nejch
feat(objects): add support for group audit events API
2a0fbdf
@nejch
nejch force-pushed the feat/all-audit-events branch from 23e37c5 to 2a0fbdf Compare March 7, 2021 14:00
@nejch nejch assigned max-wittig Mar 7, 2021
@max-wittig

max-wittig commented Mar 24, 2021

Copy link
Copy Markdown
Member

@nejch Sorry for ignoring that for soo long. Looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@max-wittig
max-wittig merged commit 02ce49e into master Mar 24, 2021
@max-wittig
max-wittig deleted the feat/all-audit-events branch March 24, 2021 10:11
This was referenced Apr 25, 2021
chore(objects): remove noisy deprecation warning for audit events #1414
Merged
chore: bump version to 2.7.0 #1408
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@max-wittig max-wittig

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for group audit events Add support for audit events

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nejch @codecov-io @max-wittig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.