GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(objects): remove noisy deprecation warning for audit events by nejch · Pull Request #1414 · python-gitlab/python-gitlab

Conversation

@nejch

@nejch nejch commented Apr 25, 2021

Copy link
Copy Markdown
Member

When I added this in #1363 I missed that it always gets instantiated and everyone will be getting the warning. It's mostly an internal thing anyway and can be removed in 3.0.0.

Needed for 2.7.0 #1408 so people don't get spammed 😁

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nejch nejch assigned max-wittig Apr 25, 2021
@codecov-commenter

codecov-commenter commented Apr 25, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1414 (2953642) into master (4f79dff) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
- Coverage   80.20%   80.17%   -0.03%     
==========================================
  Files          73       73              
  Lines        4067     4061       -6     
==========================================
- Hits         3262     3256       -6     
  Misses        805      805
Flag Coverage Δ
unit 80.17% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/audit_events.py 100.00% <ø> (ø)
gitlab/client.py 78.96% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc42d2...2953642. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nejch
chore(objects): remove noisy deprecation warning for audit events
2953642 
It's mostly an internal thing anyway and can be removed in 3.0.0
@nejch
nejch force-pushed the chore/remove-noisy-deprecation-warning branch from 5453c60 to 2953642 Compare April 25, 2021 12:31
@nejch nejch mentioned this pull request Apr 25, 2021
chore: bump version to 2.7.0 #1408
Merged
@max-wittig
max-wittig merged commit 0a0fcaf into master Apr 25, 2021
@nejch
nejch deleted the chore/remove-noisy-deprecation-warning branch May 30, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@max-wittig max-wittig

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nejch @codecov-commenter @max-wittig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.