GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: bump version to 2.7.0 by max-wittig · Pull Request #1408 · python-gitlab/python-gitlab

Conversation

@max-wittig

@max-wittig max-wittig commented Apr 23, 2021

Copy link
Copy Markdown
Member

@nejch I think it's time again to release. It's been a while

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@max-wittig
chore: bump version to 2.7.0
34c4052
@max-wittig
max-wittig requested a review from nejch April 23, 2021 14:40
@max-wittig max-wittig assigned nejch Apr 23, 2021
@JohnVillalovos

JohnVillalovos commented Apr 23, 2021

Copy link
Copy Markdown
Member

Cool! I like a new release 😊

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JohnVillalovos
JohnVillalovos approved these changes Apr 23, 2021
View reviewed changes
@nejch nejch mentioned this pull request Apr 25, 2021
chore(objects): remove noisy deprecation warning for audit events #1414
Merged
@nejch

nejch commented Apr 25, 2021

Copy link
Copy Markdown
Member

Yay, agreed! 😸

I'd just like to fix one small thing before this goes out, when I added #1363 the deprecationwarning was too eager and on master now everyone gets it when Gitlab is instantiated:

>>> gl = Gitlab.from_config()
/home/nejc/repos/python-gitlab/gitlab/v4/objects/audit_events.py:70: DeprecationWarning: This class has been renamed to ProjectAuditEvent and will be removed in a future release.
  class ProjectAudit(ProjectAuditEvent):
/home/nejc/repos/python-gitlab/gitlab/v4/objects/audit_events.py:74: DeprecationWarning: This class has been renamed to ProjectAuditEventManager and will be removed in a future release.
  class ProjectAuditManager(ProjectAuditEventManager):

@max-wittig could you merge #1414 and then this is ready? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@max-wittig

max-wittig commented Apr 25, 2021

Copy link
Copy Markdown
Member Author

Thinking about it, this version should anyway be called 3.0.0, as we introduced some breaking changes with the way kwargs are used.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nejch

nejch commented Apr 25, 2021

Copy link
Copy Markdown
Member

Thinking about it, this version should anyway be called 3.0.0, as we introduced some breaking changes with the way kwargs are used.

Oh, you mean #1278? That's not merged yet 😊

I was hoping to finish #1296 for 3.0.0 as that would be a very popular feature IMO but might also have some breaking behavior.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@max-wittig

max-wittig commented Apr 25, 2021

Copy link
Copy Markdown
Member Author

Makes sense. I merged it. Let's go for 2.7.0 then 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nejch
nejch merged commit e37de18 into master Apr 25, 2021
@nejch
nejch deleted the chore/bump-to-2-7-0 branch April 25, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes
@nejch nejch Awaiting requested review from nejch

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nejch nejch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@max-wittig @JohnVillalovos @nejch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.