GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — Expose PIR enabled setting for iot dimmers by rytilahti · Pull Request #1174 · python-kasa/python-kasa Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #1174 +/- ## ========================================== + Coverage 92.49% 92.56% +0.06% ========================================== Files 99 99 Lines 6532 6548 +16 Branches 1615 702 -913 ========================================== + Hits 6042 6061 +19 + Misses 373 367 -6 - Partials 117 120 +3 ☔ View full report in Codecov by Sentry. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sdb9696
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the smart modules tests, the test files should live in kasa/tests/iot/modules, other than that LGTM!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
-
👍 1 reaction
eternalliving
commented
Nov 2, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
|
I was unable to get the PIR module to show with the KS200M. It doesn't show under modules when querying dev.modules in a script. Using kasa feature on cli does show the ambient_light feature though, but still no PIR. Note: the KS200M isn't a dimmer, but does have motion and ambient light sensors. Would this be better posted as an issue? |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Yes, please create a new issue for this. It'd also be great if you could provide a fixture file (described in the contributing docs), just in case it differs from the existing ones. Iirc, the necessary modules are only initialized for devices that are considered as dimmers. So the fix involves finding a nice way to get this detected as such, as most kasa devices do not provide a way to detect supported features. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti) - Add childprotection module [\#1141](#1141) (@rytilahti) - Initial trigger logs implementation [\#900](#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\#1220](#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\#1225](#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696) - Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
This adds PIR enabled feature to iot dimmers, making it possible to enable and disable the motion detection.
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](python-kasa/python-kasa@0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\python-kasa#1227](python-kasa#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\python-kasa#1210](python-kasa#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\python-kasa#1174](python-kasa#1174) (@rytilahti) - Add childprotection module [\python-kasa#1141](python-kasa#1141) (@rytilahti) - Initial trigger logs implementation [\python-kasa#900](python-kasa#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\python-kasa#1220](python-kasa#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\python-kasa#1225](python-kasa#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\python-kasa#1224](python-kasa#1224) (@sdb9696) - Add component queries to smartcamera devices [\python-kasa#1223](python-kasa#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\python-kasa#1222](python-kasa#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\python-kasa#1219](python-kasa#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\python-kasa#1138](python-kasa#1138) (@rytilahti)
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Projects
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
3 participants
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.