GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update try_connect_all to be more efficient and report attempts by sdb9696 · Pull Request #1222 · python-kasa/python-kasa

Conversation

@sdb9696

@sdb9696 sdb9696 commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sdb9696
Update try_connect_all to be more efficient and report attempts
34caf8c
@codecov

codecov Bot commented Nov 1, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (e73da5b) to head (045c115).
Report is 208 commits behind head on master.

Files with missing lines Patch % Lines
kasa/discover.py 86.36% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   92.60%   92.55%   -0.06%     
==========================================
  Files          99      100       +1     
  Lines        6558     6607      +49     
  Branches      703      708       +5     
==========================================
+ Hits         6073     6115      +42     
- Misses        364      370       +6     
- Partials      121      122       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696
Fix coverage
b3ae3b4
@sdb9696
sdb9696 requested a review from rytilahti November 1, 2024 16:34
@sdb9696
Use named tuple for on_attempt
714fdd5
rytilahti
rytilahti approved these changes Nov 1, 2024
View reviewed changes

@rytilahti rytilahti left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a great fan of the added complexity, but I suppose we cannot do without it. Just a couple of nits that might make it a bit more readable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread kasa/device_factory.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread kasa/discover.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sdb9696
Rename no warn to require exact
045c115
rytilahti
rytilahti approved these changes Nov 1, 2024
View reviewed changes
@sdb9696
sdb9696 merged commit 77b654a into master Nov 1, 2024
@sdb9696
sdb9696 deleted the feat/try_conn_cli branch November 1, 2024 18:17
@sdb9696 sdb9696 added this to the 0.7.7 milestone Nov 4, 2024
@sdb9696 sdb9696 added the maintenance Project improvements and maintenance label Nov 4, 2024
@sdb9696 sdb9696 mentioned this pull request Nov 4, 2024
Prepare 0.7.7 #1229
Merged
sdb9696 added a commit that referenced this pull request Nov 4, 2024
@sdb9696
Prepare 0.7.7 (#1229)
331baf6 
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04)

[Full Changelog](0.7.6...0.7.7)

**Release summary:**

- Bugfix for child device device creation error with credentials_hash
- PIR support for iot dimmers and wall switches.
- Various small enhancements and project improvements.

**Implemented enhancements:**

- Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti)
- Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti)
- Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti)
- Add childprotection module [\#1141](#1141) (@rytilahti)
- Initial trigger logs implementation [\#900](#900) (@rytilahti)

**Fixed bugs:**

- Fix AES child device creation error [\#1220](#1220) (@sdb9696)

**Project maintenance:**

- Update TC65 fixture [\#1225](#1225) (@rytilahti)
- Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696)
- Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696)
- Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696)
- Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti)
- parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Update try_connect_all to be more efficient and report attempts (pyth…
d97d393 
…on-kasa#1222)
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@sdb9696
Prepare 0.7.7 (python-kasa#1229)
c91fc85 
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04)

[Full Changelog](python-kasa/python-kasa@0.7.6...0.7.7)

**Release summary:**

- Bugfix for child device device creation error with credentials_hash
- PIR support for iot dimmers and wall switches.
- Various small enhancements and project improvements.

**Implemented enhancements:**

- Add PIR&LAS for wall switches mentioning PIR support [\python-kasa#1227](python-kasa#1227) (@rytilahti)
- Expose ambient light setting for iot dimmers [\python-kasa#1210](python-kasa#1210) (@rytilahti)
- Expose PIR enabled setting for iot dimmers [\python-kasa#1174](python-kasa#1174) (@rytilahti)
- Add childprotection module [\python-kasa#1141](python-kasa#1141) (@rytilahti)
- Initial trigger logs implementation [\python-kasa#900](python-kasa#900) (@rytilahti)

**Fixed bugs:**

- Fix AES child device creation error [\python-kasa#1220](python-kasa#1220) (@sdb9696)

**Project maintenance:**

- Update TC65 fixture [\python-kasa#1225](python-kasa#1225) (@rytilahti)
- Update smartcamera fixtures from latest dump\_devinfo [\python-kasa#1224](python-kasa#1224) (@sdb9696)
- Add component queries to smartcamera devices [\python-kasa#1223](python-kasa#1223) (@sdb9696)
- Update try\_connect\_all to be more efficient and report attempts [\python-kasa#1222](python-kasa#1222) (@sdb9696)
- Use stacklevel=2 for warnings to report on callsites [\python-kasa#1219](python-kasa#1219) (@rytilahti)
- parse\_pcap\_klap: various code cleanups [\python-kasa#1138](python-kasa#1138) (@rytilahti)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

maintenance Project improvements and maintenance

Projects

None yet

Milestone

0.7.7

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sdb9696 @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.