GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Raise UnsupportedDeviceError instead of crashing on unknown device types by GhostCoder6969 · Pull Request #1781 · python-kasa/python-kasa

Conversation

GhostCoder6969 commented Oct 4, 2026

Copy link

Copy Markdown

Contributor

I hit the same KeyError on my network, my EC60 shows up as IOT.IPCAMERA and the whole discovery run dies.

I changed get_device_class_from_sys_info so an unknown type raises UnsupportedDeviceError, which discovery already catches and reports as unsupported. I added a regression test for the legacy camera sysinfo and it realy fails without the fix.

Tests, uv run pytest tests/test_device_factory.py tests/test_discovery.py, 3568 passed. ruff check and ruff format clean. Fixes #1753

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Handle unsupported device types during discovery

b597ecb

rytilahti reviewed

Oct 4, 2026

View reviewed changes

rytilahti left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, that this has not caused issues earlier... Thanks for the PR @GhostCoder6969, I added a small nit on how I would personally make the check to keep it simpler. Take a look and let me know what you think!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

kasa/device_factory.py Outdated

		device_type = IotDevice._get_device_type_from_sys_info(sysinfo)
		try:
		return TYPE_TO_CLASS[device_type]
		except KeyError as ex:

rytilahti Oct 4, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of try-catching, you could do something like:

if (cls := TYPE_TO_CLASS.get(device_type) is None:
    # raise exception

return cls

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

GhostCoder6969 Oct 4, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, much cleaner. I switched it to the get with None check and the tests still pass. Thanks for looking at it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rytilahti added the bug Something isn't working label

Oct 4, 2026

rytilahti changed the title ~~I fixed the crash when discovery meets a camera it does not support yet~~ Raise UnsupportedDeviceError instead of crashing on unknown device types

Oct 4, 2026

codecov Bot commented Oct 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.43%. Comparing base (5b8447c) to head (55b8bfe).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1781      +/-   ##
==========================================
+ Coverage   93.42%   93.43%   +0.01%     
==========================================
  Files         159      159              
  Lines       10113    10116       +3     
  Branches     1043     1044       +1     
==========================================
+ Hits         9448     9452       +4     
+ Misses        472      471       -1     
  Partials      193      193

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          use get with None check instead of try except

55b8bfe

GhostCoder6969 commented Oct 4, 2026

Copy link

Copy Markdown

Contributor Author

Switched to the get with None check like you suggested, tests still green on my end.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rytilahti approved these changes

Oct 12, 2026

View reviewed changes

rytilahti left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great to see changes making the discovery path more robust, thanks @GhostCoder6969!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rytilahti enabled auto-merge (squash)

October 12, 2026 21:29

rytilahti disabled auto-merge

October 12, 2026 21:29

rytilahti merged commit a4fe376 into python-kasa:master

Oct 12, 2026

21 of 22 checks passed

Uh oh!

There was an error while loading. Please reload this page.

rytilahti mentioned this pull request

Oct 25, 2026

Prepare 0.12.0 #1811

Merged

rytilahti added a commit that referenced this pull request

Oct 25, 2026


          Prepare 0.12.0 (#1811)

a178fba

## [0.12.0](https://github.com/python-kasa/python-kasa/tree/0.12.0)
(2026-10-25)

This release include several compatibility fixes (updated accepted SSL
ciphers, removal of Homekit from the default update cycle).
The new API `Device.supports_module()` provide a way to find out if the
device supports some specific module, e.g., HomeKit, without including
it in the default update cycle.

[Full
Changelog](0.11.0.1...0.12.0)

**Fixed bugs:**

- Keep hub children when the child component list is missing
[\#1797](#1797)
(@Richardtristan)
- Strip multi-word rich tags when rich is not installed
[\#1807](#1807)
(@wolfgang-aura)
- Add Device.supports_module() and stop querying HomeKit for iot devices
[\#1808](#1808)
(@rytilahti)
- Keep multi requests for smartcam devices after a timeout
[\#1802](#1802)
(@hugaraujo)
- Consolidate SSL ciphers and use them in SslTransport
[\#1798](#1798)
(@rytilahti)
- Raise UnsupportedDeviceError instead of crashing on unknown device
types [\#1781](#1781)
(@GhostCoder6969)

**Added support for devices:**

- Add TD21(EU) device fixture
[\#1786](#1786)
(@Smugaski)
- Add P116M(IN) fixture
[\#1795](#1795)
(@Partha-dev01)

**Project maintenance:**

- Add Python 3.15 to supported versions and update pins
[\#1793](#1793)
(@rytilahti)
- Generate the changelog with git-cliff and draft releases in CI
[\#1809](#1809)
(@rytilahti)
- Build and check packages in CI and publish workflows
[\#1782](#1782)
(@rytilahti)

**Other changes:**

- Use the real discovery reply in the TD21 fixture
[\#1800](#1800)
(@Smugaski)

rytilahti mentioned this pull request

Oct 25, 2026

Bump python-kasa to 0.12.0 home-assistant/core#188594

Merged

2 of 21 tasks

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 30, 2026


          Raise UnsupportedDeviceError instead of crashing on unknown device ty…

…pes (python-kasa#1781)

Use get() instead of index accessor to avoid crashing on unknown devices.

---------

Co-authored-by: GhostCoder6969 <[email protected]>

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 30, 2026


          Prepare 0.12.0 (python-kasa#1811)

7ddf1ef

## [0.12.0](https://github.com/python-kasa/python-kasa/tree/0.12.0)
(2026-10-25)

This release include several compatibility fixes (updated accepted SSL
ciphers, removal of Homekit from the default update cycle).
The new API `Device.supports_module()` provide a way to find out if the
device supports some specific module, e.g., HomeKit, without including
it in the default update cycle.

[Full
Changelog](python-kasa/python-kasa@0.11.0.1...0.12.0)

**Fixed bugs:**

- Keep hub children when the child component list is missing
[\python-kasa#1797](python-kasa#1797)
(@Richardtristan)
- Strip multi-word rich tags when rich is not installed
[\python-kasa#1807](python-kasa#1807)
(@wolfgang-aura)
- Add Device.supports_module() and stop querying HomeKit for iot devices
[\python-kasa#1808](python-kasa#1808)
(@rytilahti)
- Keep multi requests for smartcam devices after a timeout
[\python-kasa#1802](python-kasa#1802)
(@hugaraujo)
- Consolidate SSL ciphers and use them in SslTransport
[\python-kasa#1798](python-kasa#1798)
(@rytilahti)
- Raise UnsupportedDeviceError instead of crashing on unknown device
types [\python-kasa#1781](python-kasa#1781)
(@GhostCoder6969)

**Added support for devices:**

- Add TD21(EU) device fixture
[\python-kasa#1786](python-kasa#1786)
(@Smugaski)
- Add P116M(IN) fixture
[\python-kasa#1795](python-kasa#1795)
(@Partha-dev01)

**Project maintenance:**

- Add Python 3.15 to supported versions and update pins
[\python-kasa#1793](python-kasa#1793)
(@rytilahti)
- Generate the changelog with git-cliff and draft releases in CI
[\python-kasa#1809](python-kasa#1809)
(@rytilahti)
- Build and check packages in CI and publish workflows
[\python-kasa#1782](python-kasa#1782)
(@rytilahti)

**Other changes:**

- Use the real discovery reply in the TD21 fixture
[\python-kasa#1800](python-kasa#1800)
(@Smugaski)

Reviewers

rytilahti

rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

bug

Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsupported IOT.IPCAMERA devices raise a bare KeyError from get_device_class_from_sys_info during discovery (fix written in #1571, closed by stale bot)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

GhostCoder6969 commented Oct 4, 2026

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

rytilahti Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

GhostCoder6969 Oct 4, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GhostCoder6969 commented Oct 4, 2026

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Oct 4, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.