GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add TD21(EU) device fixture by Smugaski · Pull Request #1786 · python-kasa/python-kasa

Conversation

Smugaski commented Oct 7, 2026

Copy link

Copy Markdown

Contributor

Add TD21(EU) device fixture

Adds a device fixture for the Tapo TD21 doorbell, hardware 2.0 (EU), firmware 1.1.5 Build 260423 Rel.6435n.

Changes

Adds tests/fixtures/smartcam/TD21(EU)_2.0_1.1.5.json.
Regenerates the supported-device lists in README.md and SUPPORTED.md with devtools/generate_supported.py.

No library code changes were needed. The device connects over the existing smartcam protocol (SMART.TAPODOORBELL, AES over HTTPS on port 443) and is picked up as a Doorbell.

Notes

The fixture's discovery_result block is hand-written, not captured. The TD21 does not answer UDP discovery (kasa discover times out), so it was modelled on the D130 fixture using the TD21's real model, hardware version and firmware version. It is needed because the discovery and device-factory tests expect it for every smartcam fixture.
The dump was generated with devtools/dump_devinfo.py against the device directly, using --device-family SMART.TAPODOORBELL --encrypt-type AES --https. Device IDs, MAC suffix, device name, SSID and location are redacted.

Testing

All tests parametrized on the TD21 fixture pass locally (108 passed, 2 skipped).
pre-commit formatting hooks pass on the changed files, and the supported-devices generator produces no further changes.
I could not get a clean full-suite run on Windows: the run intermittently hangs in asyncio's loopback socketpair() setup, in different tests each time and also on an unmodified checkout. Relying on CI for the full run.

Not included

The device also reports ring, chimeCtrl, quickResponse and doorbellNightVision components. They are not exposed as features yet, and I left that for a separate change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add TD21(EU) device fixture

266d08f

codecov Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.43%. Comparing base (ff26187) to head (3ce876f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1786      +/-   ##
==========================================
+ Coverage   93.41%   93.43%   +0.02%     
==========================================
  Files         159      159              
  Lines       10113    10116       +3     
  Branches     1043     1044       +1     
==========================================
+ Hits         9447     9452       +5     
+ Misses        472      471       -1     
+ Partials      194      193       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rytilahti added the new device New device supported due to fixture being added label

Oct 12, 2026

rytilahti approved these changes

Oct 12, 2026

View reviewed changes

rytilahti left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Smugaski, I saw that you mention that the discovery information is prepared manually, this is good to know!

I think this is good to go, but we should figure out a way to mark such manually maintained items to let the readers know that it is not a real device response. I will think on it a bit before merging, but if you have an idea, please feel free to let me know and/or adjust the fixture file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Mark TD21 discovery_result as manually created

a611c1f

The TD21 does not answer UDP discovery, so the discovery_result block is not a real device response. Add a _comment key next to error_code and result so readers can tell. The key sits outside the result dict that is parsed into the discovery model, and the fixture round-trip and discovery tests still pass.

Smugaski commented Oct 13, 2026

Copy link

Copy Markdown

Contributor Author

Thanks for taking a look!
On marking the hand-written block, here are two options.

The first is a _comment key inside discovery_result, next to error_code and result, saying it's manually created and what it was modelled on. I tried this locally: it stays out of the result dict that gets parsed into the discovery model, and the TD21 tests (including the fixture round-trip in test_smartcam_fixtures) still pass.
The second is to leave the fixture as it is and rely on the PR description, which already says the block is hand-written and modelled on the D130 fixture.

I'm happy to do either, or something different if you have a convention in mind. I didn't want to invent one in a fixture-only PR. Please let me know which you'd prefer, or if you have any other ideas in mind.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rytilahti commented Oct 13, 2026

Copy link

Copy Markdown

Member

Having a _comment sounds good, as it doesn't require checking the PR, thanks! I can adjust the other manually constructed fixtures to follow your example.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Smugaski commented Oct 13, 2026

Copy link

Copy Markdown

Contributor Author

Pushed the _comment to the PR. For reference, I put it directly inside discovery_result so it stays clear of the result dict that gets parsed.

rytilahti reacted with rocket emoji

All reactions

🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Shorten TD21 fixture comment to fit discover raw output

3ce876f

The CLI prints through rich, which wraps at 80 columns when output is not a terminal. The long comment wrapped and broke the exact-match comparison in test_discover_raw. Keep the comment short enough to stay on one line.

Smugaski commented Oct 13, 2026

Copy link

Copy Markdown

Contributor Author

Pushed a small follow-up: the first _comment was too long and failed test_discover_raw in CI. kasa discover raw prints through rich, which wraps at 80 columns when output isn't a terminal, and the test compares the output exactly. I shortened it to "Manually created, not a real device response." (the line is 64 columns). Worth knowing for the other manually built fixtures: the whole printed line, including indentation, has to stay under 80 columns, so a short generic comment works best.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rytilahti approved these changes

Oct 13, 2026

View reviewed changes

rytilahti merged commit f1a8d38 into python-kasa:master

Oct 13, 2026

21 of 22 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Smugaski mentioned this pull request

Oct 13, 2026

Use the real discovery reply in the TD21 fixture #1800

Merged

rytilahti mentioned this pull request

Oct 25, 2026

Prepare 0.12.0 #1811

Merged

rytilahti added a commit that referenced this pull request

Oct 25, 2026


          Prepare 0.12.0 (#1811)

a178fba

## [0.12.0](https://github.com/python-kasa/python-kasa/tree/0.12.0)
(2026-10-25)

This release include several compatibility fixes (updated accepted SSL
ciphers, removal of Homekit from the default update cycle).
The new API `Device.supports_module()` provide a way to find out if the
device supports some specific module, e.g., HomeKit, without including
it in the default update cycle.

[Full
Changelog](0.11.0.1...0.12.0)

**Fixed bugs:**

- Keep hub children when the child component list is missing
[\#1797](#1797)
(@Richardtristan)
- Strip multi-word rich tags when rich is not installed
[\#1807](#1807)
(@wolfgang-aura)
- Add Device.supports_module() and stop querying HomeKit for iot devices
[\#1808](#1808)
(@rytilahti)
- Keep multi requests for smartcam devices after a timeout
[\#1802](#1802)
(@hugaraujo)
- Consolidate SSL ciphers and use them in SslTransport
[\#1798](#1798)
(@rytilahti)
- Raise UnsupportedDeviceError instead of crashing on unknown device
types [\#1781](#1781)
(@GhostCoder6969)

**Added support for devices:**

- Add TD21(EU) device fixture
[\#1786](#1786)
(@Smugaski)
- Add P116M(IN) fixture
[\#1795](#1795)
(@Partha-dev01)

**Project maintenance:**

- Add Python 3.15 to supported versions and update pins
[\#1793](#1793)
(@rytilahti)
- Generate the changelog with git-cliff and draft releases in CI
[\#1809](#1809)
(@rytilahti)
- Build and check packages in CI and publish workflows
[\#1782](#1782)
(@rytilahti)

**Other changes:**

- Use the real discovery reply in the TD21 fixture
[\#1800](#1800)
(@Smugaski)

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 30, 2026


          Add TD21(EU) device fixture (python-kasa#1786)

74d0c82

Adds a device fixture for the **Tapo TD21** doorbell, hardware 2.0 (EU),
firmware 1.1.5 Build 260423 Rel.6435n.

The fixture's `discovery_result` block is **hand-written**, not
captured.


---------

Co-authored-by: Smugaski <[email protected]>

pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request

Oct 30, 2026


          Prepare 0.12.0 (python-kasa#1811)

7ddf1ef

## [0.12.0](https://github.com/python-kasa/python-kasa/tree/0.12.0)
(2026-10-25)

This release include several compatibility fixes (updated accepted SSL
ciphers, removal of Homekit from the default update cycle).
The new API `Device.supports_module()` provide a way to find out if the
device supports some specific module, e.g., HomeKit, without including
it in the default update cycle.

[Full
Changelog](python-kasa/python-kasa@0.11.0.1...0.12.0)

**Fixed bugs:**

- Keep hub children when the child component list is missing
[\python-kasa#1797](python-kasa#1797)
(@Richardtristan)
- Strip multi-word rich tags when rich is not installed
[\python-kasa#1807](python-kasa#1807)
(@wolfgang-aura)
- Add Device.supports_module() and stop querying HomeKit for iot devices
[\python-kasa#1808](python-kasa#1808)
(@rytilahti)
- Keep multi requests for smartcam devices after a timeout
[\python-kasa#1802](python-kasa#1802)
(@hugaraujo)
- Consolidate SSL ciphers and use them in SslTransport
[\python-kasa#1798](python-kasa#1798)
(@rytilahti)
- Raise UnsupportedDeviceError instead of crashing on unknown device
types [\python-kasa#1781](python-kasa#1781)
(@GhostCoder6969)

**Added support for devices:**

- Add TD21(EU) device fixture
[\python-kasa#1786](python-kasa#1786)
(@Smugaski)
- Add P116M(IN) fixture
[\python-kasa#1795](python-kasa#1795)
(@Partha-dev01)

**Project maintenance:**

- Add Python 3.15 to supported versions and update pins
[\python-kasa#1793](python-kasa#1793)
(@rytilahti)
- Generate the changelog with git-cliff and draft releases in CI
[\python-kasa#1809](python-kasa#1809)
(@rytilahti)
- Build and check packages in CI and publish workflows
[\python-kasa#1782](python-kasa#1782)
(@rytilahti)

**Other changes:**

- Use the real discovery reply in the TD21 fixture
[\python-kasa#1800](python-kasa#1800)
(@Smugaski)

Reviewers

rytilahti

rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

new device

New device supported due to fixture being added

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Smugaski commented Oct 7, 2026

Add TD21(EU) device fixture

Changes

Notes

Testing

Not included

Uh oh!

codecov Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rytilahti left a comment

Choose a reason for hiding this comment

Uh oh!

Smugaski commented Oct 13, 2026

Uh oh!

rytilahti commented Oct 13, 2026

Uh oh!

Smugaski commented Oct 13, 2026

Uh oh!

Smugaski commented Oct 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.