GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make timeout adjustable by bdraco · Pull Request #494 · python-kasa/python-kasa

Conversation

@bdraco

@bdraco bdraco commented Aug 4, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bdraco bdraco mentioned this pull request Aug 4, 2023
TP-Link/Kasa integration frequent problem with connection or updating home-assistant/core#93312
Closed
@codecov-commenter

codecov-commenter commented Aug 4, 2023 •
edited by codecov Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
kasa/discover.py 84.24% <100.00%> (+0.10%) ⬆️
kasa/protocol.py 86.66% <100.00%> (ø)
kasa/smartbulb.py 91.70% <100.00%> (ø)
kasa/smartdevice.py 87.60% <100.00%> (ø)
kasa/smartdimmer.py 84.44% <100.00%> (ø)
kasa/smartlightstrip.py 93.47% <100.00%> (ø)
kasa/smartplug.py 100.00% <100.00%> (ø)
kasa/smartstrip.py 87.19% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti

rytilahti commented Oct 4, 2023

Copy link
Copy Markdown
Member

@bdraco should this be de-drafted to be included in the next upcoming release?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bdraco

bdraco commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

I need to write tests for it, but I'm been really short on time since I've been traveling so much (haven't been the same timezone for more than a few days at a time over the last 30 days) so I haven't had a chance to get back to these.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rytilahti rytilahti added this to the 0.5.4 milestone Oct 4, 2023
@rytilahti rytilahti added the enhancement New feature or request label Oct 4, 2023
@rytilahti

rytilahti commented Oct 4, 2023

Copy link
Copy Markdown
Member

No worries, just wanted to give a friendly ping :-) I think it's for the best to delay a new release to get your open PRs (and hopefully #509, too) in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bdraco

bdraco commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

I should be home for the latter end of next week unless something comes up. Once I catch up on sleep, I'll try to catch up on all my PR backlog
rytilahti reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bdraco
rebase, test
0c97da5
@bdraco
bdraco force-pushed the connecton_timeout branch from 8697770 to 0c97da5 Compare October 7, 2023 17:29
@bdraco
rebase, test
43d8939
@bdraco
bdraco marked this pull request as ready for review October 7, 2023 17:36
@bdraco bdraco mentioned this pull request Oct 7, 2023
Add a connect_single method to Discover to avoid the need for UDP #528
Merged
rytilahti
rytilahti approved these changes Oct 7, 2023
View reviewed changes

@rytilahti rytilahti left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdraco! 👍

We should probably add a cli parameter for this, but that can be done in a separate PR. Related to #310.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rytilahti rytilahti mentioned this pull request Oct 7, 2023
Set timeout using command line parameters #310
Closed
@rytilahti
rytilahti merged commit 0ec0826 into python-kasa:master Oct 7, 2023
@bdraco
bdraco deleted the connecton_timeout branch October 7, 2023 19:07
@rytilahti rytilahti mentioned this pull request Oct 8, 2023
Add klap protocol #509
Merged
@sdb9696 sdb9696 mentioned this pull request Nov 1, 2023
Move connect_single to SmartDevice.connect #538
Merged
@rytilahti rytilahti mentioned this pull request Dec 3, 2023
Make timeout configurable for cli #564
Merged
pillarsdotnet pushed a commit to pillarsdotnet/python-kasa that referenced this pull request Oct 22, 2026
@bdraco
Make timeout adjustable (python-kasa#494)
c328fb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytilahti rytilahti rytilahti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.5.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bdraco @codecov-commenter @rytilahti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.