GeezerVison

Great work on those other PRs, this PR is now so much easier to review! :-)

I added some comments, but could you please add some initial tests? Even initializing the klapprotocol class without any real tests would make it much easier to read as codecov would not warn on every code block.

Sorry for keep you waiting @sdb9696, I was traveling and too busy with other things but I finally sat down and took a look into the klapprotocol, and added plenty of comments on how to make the code cleaner and easier to understand (and to maintain, I hope :-)).

I'll do another review with fresh eyes later, but let's start getting it cleaned for the next release :-)

Some more comments. I thought I wrote at some point about cleaning up the session handling to avoid constructing a session object for every _execute_query call and passing it around, but maybe that got lost during a rebase?

The code would become immediately much simpler, if the session would be initialized only when one does not exist (or errors) and stored in self.session to be used. This would follow the same, much more optimized approach like the regular protocol does, i.e., keep the connection to the device open to avoid the set-up overhead. Basically, using a pattern like done in the current protocol: have _connect that performs protocol initialization and implementing close() which resets the state when necessary (e.g., on errors) so that the connect will reinitialize it again.

Maybe that would also simplify the state handling, at the moment there are way, IMO, too many state instance variables which makes following the code quite hard and likely prone to errors. If you want, I could try to give that a go over the weekend and create a PR for you to test on a real device?

Hi @sdb9696 and sorry for the delay, I am currently terribly, terribly busy IRL (and will remain so for the time being) and I haven't had free cycles to think on this project for a while...

Anyway, I went through the current state briefly and I think the PR looks now so much better, thanks! So I feel that we should just merge this after the comments I added now are done, and fix whatever comes up in separate PRs.

LGTM, thanks a lot @sdb9696! 💯