GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drop Support for Python 3.7 by Bibo-Joshi · Pull Request #3728 · python-telegram-bot/python-telegram-bot

Conversation

@Bibo-Joshi

@Bibo-Joshi Bibo-Joshi commented Jun 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As Python 3.7 reaches EOL at the end of this month, it's time to say goodbye.

Before merging this PR, we should try to include as many py3.8-only features as reasonably possible without too much delay. This includes the following issues:

  • Adopt Py3.8+ features: Logging Stacklevel #3729
  • Adopt Py3.8+ features: missing_ok Parameter #3730
  • Adopt Py3.8+ features: CancelledError is a subclass of BaseException #3731
  • Adopt Py3.8+ features: Drop workaround in PicklePersistence #3732
  • Adopt Py3.8+ features: Names for asyncio tasks #3733
  • Adopt Py3.8+ features: Walrus operator #3734
  • Adopt Py3.8+ features: New Typing features #3735
  • Moreover, we should check if there are any remaining python 3.7 related special cases in the test suite.
  • Revert 03d3c33

PRs to mention:

  • Adopt Py3.8+ features: missing_ok Parameter #3742
  • Add walrus operator wherever possible #3749
  • Remove Python 3.7 workaround for PicklePersistence #3740
  • Drop CancelledError #3754
  • Make use of @final, Final and Literal #3753
  • fix error with Literal, causing tests/docs to fail #3764
  • Use @final and Literal in more places #3762
  • Pass name to asyncio.create_task #3759

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Bibo-Joshi
Remove Python 3.7 from testing, docs and packaging
c7ea5fd
@Bibo-Joshi Bibo-Joshi added 📋 do-not-merge-yet work status: do-not-merge-yet ⚙️ security affected functionality: security 🔗 python related technology: python labels Jun 2, 2023
github-actions[bot]
github-actions Bot reviewed Jun 2, 2023
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
github-actions[bot]
github-actions Bot reviewed Jun 2, 2023
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced Jun 2, 2023
Adopt Py3.8+ features: Logging Stacklevel #3729
Closed
Adopt Py3.8+ features: missing_ok Parameter #3730
Closed
Adopt Py3.8+ features: CancelledError is a subclass of BaseException #3731
Closed
Adopt Py3.8+ features: Drop workaround in PicklePersistence #3732
Closed
Adopt Py3.8+ features: Names for asyncio tasks #3733
Closed
Adopt Py3.8+ features: Walrus operator #3734
Closed
Adopt Py3.8+ features: New Typing features #3735
Closed
Bibo-Joshi and others added 2 commits June 3, 2023 15:23
@Bibo-Joshi
Re-add note on CI bots
f1784b5
@harshil21
temporarily run tests on this branch
03d3c33
Bibo-Joshi
Bibo-Joshi commented Jun 3, 2023
View reviewed changes
Comment thread tests/README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Bibo-Joshi and others added 3 commits June 4, 2023 17:08
@Bibo-Joshi
Add missing new line
4de4643
@Trifase
Adopt Py3.8+ features: missing_ok Parameter (#3742)
457e4ef
@thefunkycat
Introduce Walrus Operator (#3749)
a1c2fe7
@harshil21 harshil21 mentioned this pull request Jun 9, 2023
Add Python 3.12 beta to test matrix #3751
Merged
harshil21 and others added 7 commits June 9, 2023 18:10
@harshil21
Remove Python 3.7 Workaround for PicklePersistence (#3740)
9d3345c
@Bibo-Joshi
Merge branch 'master' into drop-py-37
8c86a34
@clot27 Aditya
Drop CancelledError (#3754)
cf71a38 
Co-authored-by: Aditya <clot27@apx_managed.vanilla>
>
@Bibo-Joshi
Make use of @final, Final and Literal (#3753)
9181369
@lemontree210
fix error with Literal, causing tests/docs to fail (#3764)
27a8683
@harshil21
Use @Final and Literal in more places (#3762)
97965b6
@Bibo-Joshi
Merge branch 'master' into drop-py-37
546cb76
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jun 26, 2023
Remove Test Artifacts Automatically #3777
Merged
Bibo-Joshi and others added 2 commits June 26, 2023 20:01
@Bibo-Joshi
Remove py py3.7 specific check in the tests
5194025
@harshil21
Pass name to asyncio.create_task (#3759)
59a932a
Bibo-Joshi added 2 commits June 29, 2023 17:49
@Bibo-Joshi
Merge branch 'master' into drop-py-37
a765c12
@Bibo-Joshi
Revert "temporarily run tests on this branch"
08c78a9 
This reverts commit 03d3c33.
@Bibo-Joshi
Bibo-Joshi marked this pull request as ready for review June 29, 2023 15:50
@Bibo-Joshi
Bibo-Joshi merged commit fb86bb3 into master Jun 29, 2023
@Bibo-Joshi
Bibo-Joshi deleted the drop-py-37 branch June 29, 2023 16:17
clot27 added a commit that referenced this pull request Jul 3, 2023
@Bibo-Joshi @harshil21
@Trifase @thefunkycat @clot27 @lemontree210 Aditya
Drop Support for Python 3.7 (#3728, #3742, #3749, #3740, #3754, #3753, …
52ce1a4 
…#3764, #3762, #3759)

Co-authored-by: Harshil <[email protected]>
Co-authored-by: Luca Bellanti <[email protected]>
Co-authored-by: thefunkycat <[email protected]>
Co-authored-by: Aditya Yadav <[email protected]>
Co-authored-by: Dmitry Kolomatskiy <[email protected]>
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

📋 do-not-merge-yet work status: do-not-merge-yet 🔗 python related technology: python ⚙️ security affected functionality: security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Bibo-Joshi @harshil21 @Trifase @thefunkycat @clot27 @lemontree210
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.