GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — fix(gemini): support structured output with tools on Gemini 3 models by waleedlatif1 · Pull Request #4184 · simstudioai/sim Conversation
Collaborator
Summary
Type of Change
TestingTested manually against the live Gemini API with comprehensive matrix covering all model/tools/schema combinations. Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
* feat(posthog): Add tracking on mothership abort (#4023) Co-authored-by: Theodore Li <[email protected]> * fix(login): fix captcha headers for manual login (#4025) * fix(signup): fix turnstile key loading * fix(login): fix captcha header passing * Catch user already exists, remove login form captcha
|
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview Adds Reviewed by Cursor Bugbot for commit 8e93c05. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR fixes structured output being silently skipped when using Gemini 3 models with tools by branching on Confidence Score: 5/5Safe to merge — targeted bug fix with correct branching logic and no regressions to Gemini 2 behavior. All findings are P2 or lower. The implementation correctly uses No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Request: responseFormat + tools?] --> B{tools present?}
B -- No --> C[responseSchema via cleanSchemaForGemini\nresponseMimeType = application/json]
B -- Yes --> D{isGemini3Model?}
D -- Yes --> E[responseJsonSchema = raw schema\nresponseMimeType = application/json\ntools kept in config]
D -- No --> F[Warn: structured output deferred\ntools kept in config]
E --> G[Tool execution loop]
F --> G
G --> H{More tool calls?}
H -- Yes --> G
H -- No --> I{isGemini3Model?}
I -- Yes --> J[Strip tools\nresponseJsonSchema inherited from baseConfig]
I -- No --> K[Strip tools\nApply responseSchema + responseMimeType]
J --> L[Final structured response]
K --> L
Reviews (2): Last reviewed commit: "refactor(gemini): use prefix-based Gemin..." | Re-trigger Greptile |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8e93c05. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…mat, logs performance improvements fix(csp): add missing analytics domains, remove unsafe-eval, fix workspace CSP gap (#4179) fix(landing): return 404 for invalid dynamic route slugs (#4182) improvement(seo): optimize sitemaps, robots.txt, and core web vitals across sim and docs (#4170) fix(gemini): support structured output with tools on Gemini 3 models (#4184) feat(brightdata): add Bright Data integration with 8 tools (#4183) fix(mothership): fix superagent credentials (#4185) fix(logs): close sidebar when selected log disappears from filtered list; cleanup (#4186)
8e93c05c
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.