GeezerVison

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 15, 2026 7:49pm

PR Summary

Medium Risk
Touches logs selection/sidebar visibility and dashboard segment-selection reset behavior; the new render-time reset logic and derived sidebar state could cause subtle UI regressions if conditions are miscomputed.

Overview
Fixes a logs UX bug by deriving effectiveSidebarOpen so the details sidebar automatically closes when the currently selected log is no longer present in the filtered/sorted list.

Refactors several logs-related components to remove unnecessary useMemo/useCallback usage and simplifies a few computed values, and changes the dashboard segment-selection reset from an effect to a key-based synchronous reset.

Also tweaks styling tokens in the dashboard LineChart, adds a hierarchical React Query key (logKeys.statsAll) for stats invalidation, and updates the persisted log-details UI store to only persist panelWidth (excluding transient isResizing).

^{Reviewed by Cursor Bugbot for commit f5d6b6f. Configure here.}

Greptile Summary

This PR fixes a bug where the log details sidebar stayed open when the selected log was filtered out of the list. Instead of using a useEffect to dispatch a close action, it derives effectiveSidebarOpen as isSidebarOpen && selectedLogIndex !== -1, which is simpler and covers all filter-clearing paths in a single expression.

The cleanup work — removing useMemo/useCallback from non-memo'd components, converting the dashboard's useEffect segment-reset to a render-time state update, adding partialize to prevent isResizing from persisting, aligning CSS variable tokens in the line chart, and adding a statsAll() prefix key for targeted invalidation — is all mechanically correct.

Confidence Score: 5/5

Safe to merge — bug fix is correct, all cleanup changes are mechanically sound.

No P0 or P1 findings. The derived-state approach for effectiveSidebarOpen is the cleaner solution. The useCallback/useMemo removals are all in non-memo'd contexts (or inside memo'd components where the removed memos were never passed to child memo'd components). The render-time setState reset in dashboard.tsx follows the documented React pattern and avoids unnecessary resets on polling refreshes. The statsAll() key and partialize additions are straightforward improvements.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Filter changes] --> B{selectedLogIndex}
    B -- "-1 (log not in list)" --> C[effectiveSidebarOpen = false]
    B -- "≥ 0 (log in list)" --> D[effectiveSidebarOpen = isSidebarOpen]
    C --> E[LogDetails isOpen=false\nSidebar visually closes]
    D --> F{isSidebarOpen}
    F -- true --> G[LogDetails isOpen=true\nSidebar stays open]
    F -- false --> H[LogDetails isOpen=false\nSidebar stays closed]
    E --> I[isSidebarOpen store value\nunchanged — context preserved]
    I --> J{Filter cleared / log\nreappears in list}
    J -- selectedLogIndex ≥ 0 --> G

_{Reviews (1): Last reviewed commit: "fix(logs): close sidebar when selected l..." | Re-trigger Greptile}