GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||
GeezerVison is showing github.com — fix: double wrap reponse of guest session handler by stylessh · Pull Request #4438 · simstudioai/sim Conversation
Contributor
Summary
Fixes #(issue) Type of Change
TestingRun locally and disable auth. You'll get a blank page on load. Checklist
Screenshots/Videos
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…ership workflow edits via sockets, ui improvements …ng improvements, posthog, secrets mutations …ration, signup method feature flags, SSO improvements * feat(posthog): Add tracking on mothership abort (simstudioai#4023) Co-authored-by: Theodore Li <[email protected]> * fix(login): fix captcha headers for manual login (simstudioai#4025) * fix(signup): fix turnstile key loading * fix(login): fix captcha header passing * Catch user already exists, remove login form captcha …nts, secrets performance, polling refactors, drag resources in mothership …y invalidation, HITL docs …endar triggers, docs updates, integrations/models pages improvements …ions, jira forms endpoints …mat, logs performance improvements fix(csp): add missing analytics domains, remove unsafe-eval, fix workspace CSP gap (simstudioai#4179) fix(landing): return 404 for invalid dynamic route slugs (simstudioai#4182) improvement(seo): optimize sitemaps, robots.txt, and core web vitals across sim and docs (simstudioai#4170) fix(gemini): support structured output with tools on Gemini 3 models (simstudioai#4184) feat(brightdata): add Bright Data integration with 8 tools (simstudioai#4183) fix(mothership): fix superagent credentials (simstudioai#4185) fix(logs): close sidebar when selected log disappears from filtered list; cleanup (simstudioai#4186) v0.6.46: mothership streaming fixes, brightdata integration …m integration, atlassian triggers v0.6.54: migration error logs …ze, subagent thinking, files sorting, agentphone integration fix(db): revert statement_timeout startup options breaking pooled connections (simstudioai#4284) v0.6.57: mothership reliability, ashby refactor, tables row count, copilot id fix, bun upgrade …rizations, mothership positional table row insertion, CI improvements, org-external users, file viewer improvements v0.6.62: fix new copilot chat creation and selection on refresh …ixes, db query optimizations, contract boundaries code hygiene, CORS, toast improvements, tables infinite query, executor robustness, reranker support …tion blocks/connectors updates
|
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview Removes the now-redundant Reviewed by Cursor Bugbot for commit 1c327da. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThe Confidence Score: 5/5Safe to merge — minimal, well-targeted fix with corresponding test updates and no regressions. The change is a one-function deletion and a single call-site update. The root cause (double wrapping) is clearly explained, the fix is correct, tests are updated, and no other callers of the removed function exist. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as better-auth Client
participant Route as GET /api/auth/get-session
participant Anon as createAnonymousSession()
Note over Client,Anon: BEFORE fix (double-wrap)
Client->>Route: GET /api/auth/get-session
Route->>Anon: createAnonymousGetSessionResponse()
Anon-->>Route: { data: { user, session } }
Route-->>Client: NextResponse.json({ data: { user, session } })
Client->>Client: wraps in data → { data: { data: { user, session } } } ❌
Note over Client,Anon: AFTER fix (single-wrap)
Client->>Route: GET /api/auth/get-session
Route->>Anon: createAnonymousSession()
Anon-->>Route: { user, session }
Route-->>Client: NextResponse.json({ user, session })
Client->>Client: wraps in data → { data: { user, session } } ✅
Reviews (2): Last reviewed commit: "remove dead code, and fix test" | Re-trigger Greptile |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1c327da. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29606901 | Triggered | Generic High Entropy Secret | a54dcbe | apps/sim/providers/utils.test.ts | View secret |
To avoid such incidents in the future consider
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
1c327da8
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.