GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix docs search with Algolia by enriquegh · Pull Request #110 · sourcegraph/docs

Conversation

@enriquegh

@enriquegh enriquegh commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
enriquegh added 2 commits February 21, 2024 11:36
@enriquegh
initial addition of docsearch react component
cfed24a
@enriquegh
replace KBarbutton with DocSearch component
a507a11
@vercel

vercel Bot commented Feb 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2024 5:42pm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot deployed to Preview February 22, 2024 18:12
View deployment
enriquegh added 2 commits February 29, 2024 11:29
@enriquegh
add docsearch metadata
bee59d7
@enriquegh
remove all kbar references
c8ea311
@vercel
vercel Bot deployed to Preview February 29, 2024 10:44
View deployment
@MaedahBatool
Merge branch 'main' into eg-algolia
0d9c90a
@vercel
vercel Bot deployed to Preview March 6, 2024 19:48
View deployment
@enriquegh
add docsearch styling to main css and overwrite dark mode attribute
1914d5e
@vercel
vercel Bot deployed to Preview March 7, 2024 18:35
View deployment
@MaedahBatool
Merge branch 'main' into eg-algolia
4f3f5ac
@vercel
vercel Bot deployed to Preview March 8, 2024 17:33
View deployment
MaedahBatool added 2 commits March 9, 2024 09:36
@MaedahBatool
Add UI changes to search bar (#136)
43cfff1
* Add search UX improvements

* CSS improvements

* TS issues fixed

* pnpm issue

* pnpm add @algolia/client-search
@MaedahBatool
Merge branch 'main' into eg-algolia
5431171
@MaedahBatool MaedahBatool changed the title WIP: Algolia Search Fix docs search with Algolia Mar 9, 2024
@vercel
vercel Bot deployed to Preview March 9, 2024 17:42
View deployment
@MaedahBatool
MaedahBatool merged commit 383da56 into main Mar 9, 2024
@MaedahBatool
MaedahBatool deleted the eg-algolia branch March 9, 2024 17:44
@sourcegraph-bot-devx sourcegraph-bot-devx mentioned this pull request Mar 9, 2024
sourcegraph/docs#110: "Fix docs search with Algolia" sourcegraph/sec-pr-audit-trail#470
Closed
@marcleblanc2 marcleblanc2 mentioned this pull request Sep 17, 2026
Remove dead code #1997
Merged
marcleblanc2 added a commit that referenced this pull request Sep 18, 2026
@marcleblanc2 @ampagent
chore: drop the kbar search index and the dead MDX video mapping
e5be987
kbar was removed in #110; the contentlayer onSuccess hook kept writing a
725 KB public/search.json that nothing fetched. src/utils/contentlayer.ts
only existed to build that index.

MDX compiles an explicit <video> to a literal element, so components.video
never ran; the rounded-xl class it set was never applied.

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b
marcleblanc2 added a commit that referenced this pull request Sep 18, 2026
@marcleblanc2 @ampagent
chore: drop the kbar search index and the dead MDX video mapping
04645b7
kbar was removed in #110; the contentlayer onSuccess hook kept writing a
725 KB public/search.json that nothing fetched. src/utils/contentlayer.ts
only existed to build that index.

MDX compiles an explicit <video> to a literal element, so components.video
never ran; the rounded-xl class it set was never applied.

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b
marcleblanc2 added a commit that referenced this pull request Sep 23, 2026
@marcleblanc2 @ampagent
chore: drop the kbar search index and the dead MDX video mapping
67abaa9
kbar was removed in #110; the contentlayer onSuccess hook kept writing a
725 KB public/search.json that nothing fetched. src/utils/contentlayer.ts
only existed to build that index.

MDX compiles an explicit <video> to a literal element, so components.video
never ran; the rounded-xl class it set was never applied.

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b
marcleblanc2 added a commit that referenced this pull request Sep 23, 2026
@marcleblanc2 @ampagent
chore: drop the kbar search index and the dead MDX video mapping
7bc4030
kbar was removed in #110; the contentlayer onSuccess hook kept writing a
725 KB public/search.json that nothing fetched. src/utils/contentlayer.ts
only existed to build that index.

MDX compiles an explicit <video> to a literal element, so components.video
never ran; the rounded-xl class it set was never applied.

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b
marcleblanc2 added a commit that referenced this pull request Sep 23, 2026
@marcleblanc2 @ampagent
chore: drop the kbar search index and the dead MDX video mapping
60bb085
kbar was removed in #110; the contentlayer onSuccess hook kept writing a
725 KB public/search.json that nothing fetched. src/utils/contentlayer.ts
only existed to build that index.

MDX compiles an explicit <video> to a literal element, so components.video
never ran; the rounded-xl class it set was never applied.

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b
marcleblanc2 added a commit that referenced this pull request Sep 23, 2026
@marcleblanc2 @ampagent
Remove dead code (#1997)
7382402
## Problem

- kbar (a ⌘K palette) was removed in #110, but its config in
`src/data/search.ts` and the contentlayer `onSuccess` hook stayed
behind, writing a 725 KB `public/search.json` on every build that
nothing fetches
- `src/utils/contentlayer.ts` only existed to build that index
- The `video` entry in `MdxComponents.tsx` never runs: MDX compiles an
explicit `<video>` to a literal element, so `components.video` is never
consulted (the `rounded-xl` class it set has never been applied)
- A knip scan turned up more dead code nothing imports:
- `docsearch/icons/index.ts` barrel and the `AlgoliaLogo`,
`NoResultsIcon`, `ControlKeyIcon`, `GoToExternalIcon` icons only it
re-exported (plus two commented-out usages and the `searchByText`
translation that only fed `AlgoliaLogo`)
- `docsearch/types/useDocSearchKeyboardEvents.ts`, a drifted copy of the
sibling hook `DocSearch.tsx` actually imports
- `src/images/logos/aws/index.ts`, generator output from before
`dev/generate-mermaid-icons.mjs` switched to `icons.generated.ts`
- `latestVersion` in `src/data/versions.ts`, exported since #48 with no
reader
- Dependencies `@iconify-json/logos`, `@iconify/types`, and `mdx` (not
MDX: a 2013 "generic documentation extractor", likely a typo-install of
`@mdx-js/mdx`)
- Absorbed from #1986 (closed in favour of this PR; the two collided on
`package.json`, the lockfile, `.gitignore`, and
`src/utils/contentlayer.ts`):
- `src/components/PreCode.tsx` (empty; the real `PreCode` lives in
`PreCodeBlock.tsx`), `src/components/ResourceEstimator.tsx` (older
duplicate of `resource-estimator/ResourceEstimator.tsx`),
`src/components/DemoLayout.tsx` (template leftover),
`src/components/TopBanner.tsx`, `src/components/icons/Globe.tsx`,
`src/components/icons/BugIcon.tsx`
- Dependencies with no import in `src/`, `dev/`, or any config:
`@docsearch/react` (only its CSS is vendored under
`src/components/search/docsearch/`), `@mdx-js/mdx` (contentlayer2 pulls
the same 3.1.1 transitively), `date-fns`, `fast-glob`, `feed`,
`prism-react-renderer`, `react-highlight-words` +
`@types/react-highlight-words`, `react-syntax-highlighter`,
`rehype-toc`, `simple-functional-loader`, `dotenv`. Kept on purpose:
`shiki` (peer of `rehype-pretty-code`) and `sharp`
- `.gitignore` entries for `public/changelog.rss` and
`public/technical-changelog.rss`: nothing generates them; the feed comes
from sourcegraph.com and `src/proxy.ts` redirects the old paths

## Change

Five commits, one per group above. 15 files deleted, 15 dependencies
removed, +1 −1585 (880 of that lockfile).

Independent of #1977 (only shared line was the `searchDocumentsPath`
comment in `src/data/search.ts`, gone here); whichever merges second
gets a one-line rebase.

## Verification

- `pnpm install --frozen-lockfile`, `npx tsc --noEmit` clean, `pnpm run
lint` at the 8-warning baseline, `pnpm run build` passes and no longer
produces `public/search.json`
- `rg -i 'kbar|search\.json'` finds nothing; `rg` finds no imports of
any deleted file, export, or dependency
- Rendered `<video>` markup on `/docs/code-monitoring` is byte-identical
before and after (it never had the class)
- Nobody fetches `search.json`: the new Algolia indexer (#2009) reads
`.contentlayer/generated/Post`, the old DocSearch crawler scraped HTML,
and Cloudflare analytics for `sourcegraph.com` show ~150 sampled
requests to `/docs/search.json` in the last 30 days, all with an empty
referer, random geos and browser UAs, and no daily cadence: scanner
noise, not a consumer

---------

Co-authored-by: Amp <[email protected]>

This branch was successfully deployed

1 active deployment
Preview — 54311711 Deployed Mar 9, 2024 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@enriquegh @MaedahBatool
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.