GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Remove dead code by marcleblanc2 · Pull Request #1997 · sourcegraph/docs Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
759b5e0 to
e5be987
Compare
a781d29 to
e7aa180
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
very nice! so much dead code 💀
So much came from us moving from kbar to algolia then we had to bring in the docsearch component instead of importing it (I think we couldn't customize otherwise) and brought too much with it.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
6b9f3cb to
dcdddd0
Compare
30bd7be to
44c94cc
Compare
44c94cc to
c50b5c7
Compare
kbar was removed in #110; the contentlayer onSuccess hook kept writing a 725 KB public/search.json that nothing fetched. src/utils/contentlayer.ts only existed to build that index. MDX compiles an explicit <video> to a literal element, so components.video never ran; the rounded-xl class it set was never applied. Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b
…exports knip flagged these and rg confirms nothing imports them: - docsearch/icons/index.ts barrel, and the AlgoliaLogo, NoResultsIcon, ControlKeyIcon, GoToExternalIcon icons only it re-exported. The two commented-out usages in Footer.tsx and NoResultsScreen.tsx go with them, along with the searchByText translation that only fed AlgoliaLogo - docsearch/types/useDocSearchKeyboardEvents.ts, a drifted copy of the sibling hook DocSearch.tsx actually imports - src/images/logos/aws/index.ts, generator output from before dev/generate-mermaid-icons.mjs switched to icons.generated.ts - latestVersion in src/data/versions.ts, exported since #48 with no reader Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b Co-authored-by: Amp <[email protected]>
- @iconify-json/logos and @iconify/types: nothing in src/, dev/, or any config references them; Mermaid icon packs come from src/images/logos/*/icons.generated.ts - mdx: not MDX at all, a 2013 "generic documentation extractor", most likely a typo-install of @mdx-js/mdx. Nothing imports it Amp-Thread-ID: https://ampcode.com/threads/T-01a0ae6a-1645-702a-a5ed-92f8b9bce33b Co-authored-by: Amp <[email protected]>
None of these packages are imported by src/, dev/, or any config file: @docsearch/react (only its CSS is vendored), @mdx-js/mdx, date-fns, fast-glob, feed, prism-react-renderer, react-highlight-words and its @types, react-syntax-highlighter, rehype-toc, simple-functional-loader, dotenv. public/changelog.rss and public/technical-changelog.rss are no longer generated here: the feed is served from sourcegraph.com (see src/data/constants.ts) and src/proxy.ts redirects to it. Amp-Thread-ID: https://ampcode.com/threads/T-01a0ad56-bd79-73ce-bc8e-a5405d0c11f2 Co-authored-by: Amp <[email protected]>
PreCode.tsx was empty; ResourceEstimator.tsx was an older copy of resource-estimator/ResourceEstimator.tsx, which MdxComponents imports; DemoLayout, TopBanner, Globe and BugIcon have no importers. allCoreContent filtered on a `draft` frontmatter field that contentlayer.config.ts does not declare and no page sets, so the production and development branches did the same thing. Amp-Thread-ID: https://ampcode.com/threads/T-01a0ad56-bd79-73ce-bc8e-a5405d0c11f2 Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0d074-2111-762a-b494-c20730dae82b Co-authored-by: Amp <[email protected]>
29ba699 to
a956aac
Compare
There was an error while loading. Please reload this page.
`src/data/versions.ts` already exports `latestVersion = versions[0]`; this replaces the four hand-written `versions[0]` references in `src/components/VersionSelector.tsx` with it, so the latest-version logic has one home. No behaviour change. `npx tsc --noEmit` and `pnpm run lint` are clean for the changed file. Follow-up to #1997, which keeps the `latestVersion` export. Co-authored-by: Amp <[email protected]>
a956aac1
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.