GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add a test to verify #80 by graysonarts · Pull Request #83 · tableau/document-api-python

Conversation

graysonarts commented Sep 19, 2016

Copy link

Copy Markdown

Contributor

This is picking up weird commits because of merging issues, but only the last commit is important.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Russell Hay and others added 8 commits

June 29, 2016 09:56


          Merge pull request #39 from RussTheAerialist/master

e6a0bba

Updating README to include information for installing from pip


          Merge pull request #66 from tableau/development

59ac21c

Releasing 0.2 to master


          Update README.md (#71)

bcd73c1

CLANotRequired


          Merge pull request #78 from tableau/development

9a098a7

Release 0.3


          Update setup.py

b37d999


          Scrub some strings in the test files (#82)

fed0de3

* Scrub some strings in the test file so they don't include internal references
* Updated some of the assets to be consistent in casing


          Fix encoding bugs in Python2 (non-ASCII characters) (#80)

6c81acb


          Add test to keep #80 from happening again

6099ba7

t8y8 approved these changes

Sep 19, 2016

View reviewed changes

t8y8 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the PR has a bunch of other commits in it -- I trust you can fix that :)

Also for some reason pep8 is failing on one of the samples, is that related to this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

graysonarts commented Sep 19, 2016

Copy link

Copy Markdown

Contributor Author

@t8y8 weird. I have pep8 running in my pre-commit hook, I don't know why it even let me check in. I'll get that fixed and merged. The other commits are a non-issue and already exist in development. It's just a weirdness with the squashing, etc. I'm starting to think we should maybe stop squashing on merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Fixing pep8 issue with missing eol

b4db97b

t8y8 commented Sep 19, 2016

Copy link

Copy Markdown

Contributor

🚀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

graysonarts merged commit 01f232f into tableau:development

Sep 19, 2016

graysonarts deleted the test-80-bugfix branch

September 19, 2016 17:14

graysonarts mentioned this pull request

Sep 19, 2016

"UnicodeDecodeError" when description has non-ascii characters #81

Closed

graysonarts pushed a commit that referenced this pull request

Oct 7, 2016


          Add a test to verify #80 (#83)

86bb63b

Reviewers

1 more reviewer

t8y8

t8y8 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.