GeezerVison

Copy link

Copy Markdown

Collaborator

d-cs force-pushed the runops/pr02-db-foundation branch from 32525bb to 9b2b67d Compare July 2, 2026 18:02

d-cs force-pushed the runops/pr03-clickhouse-tc branch from 7e5633b to d331802 Compare July 2, 2026 18:02

npm i https://pkg.pr.new/@trigger.dev/build@9612579

npm i https://pkg.pr.new/trigger.dev@9612579

npm i https://pkg.pr.new/@trigger.dev/core@9612579

npm i https://pkg.pr.new/@trigger.dev/python@9612579

npm i https://pkg.pr.new/@trigger.dev/react-hooks@9612579

npm i https://pkg.pr.new/@trigger.dev/redis-worker@9612579

npm i https://pkg.pr.new/@trigger.dev/rsc@9612579

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@9612579

npm i https://pkg.pr.new/@trigger.dev/sdk@9612579

d-cs force-pushed the runops/pr02-db-foundation branch from d1fd926 to dc3d806 Compare July 2, 2026 19:25

d-cs force-pushed the runops/pr03-clickhouse-tc branch 2 times, most recently from 857e7d6 to 6062eac Compare July 3, 2026 08:51

d-cs force-pushed the runops/pr02-db-foundation branch from 026833a to bb1bd8f Compare July 3, 2026 09:12

d-cs force-pushed the runops/pr03-clickhouse-tc branch from 6062eac to 086715f Compare July 3, 2026 09:12

d-cs force-pushed the runops/pr02-db-foundation branch from 23edf6d to 739c923 Compare July 3, 2026 09:57

d-cs force-pushed the runops/pr03-clickhouse-tc branch from 0c9f1bb to 271eca8 Compare July 3, 2026 09:57

d-cs force-pushed the runops/pr02-db-foundation branch from 739c923 to ea51491 Compare July 3, 2026 10:33

d-cs force-pushed the runops/pr03-clickhouse-tc branch 2 times, most recently from eaa09cf to bf7ca7d Compare July 3, 2026 10:43

Base automatically changed from runops/pr02-db-foundation to main July 3, 2026 11:05

d-cs force-pushed the runops/pr03-clickhouse-tc branch from bf7ca7d to 9612579 Compare July 3, 2026 11:08

d-cs marked this pull request as ready for review July 3, 2026 11:22

ericallam approved these changes Jul 3, 2026

View reviewed changes

46 checks passed

d-cs deleted the runops/pr03-clickhouse-tc branch July 3, 2026 12:02

## What

Introduces the run-store routing seam and the run-engine read seams that
let run lifecycle operations be dispatched to either the control-plane
database or a separately-generated run-ops database, depending on where
a run/batch resides.

- **run-store** (`internal-packages/run-store`): adds `runOpsStore.ts`
and substantially expands `PostgresRunStore.ts` so the store can resolve
residency and route reads/writes to the correct backing client.
`types.ts` grows the routing/residency types; `NoopRunStore.ts` is
removed.
- **run-engine** (`internal-packages/run-engine`): adds
`engine/controlPlaneResolver.ts` and routes the per-system read paths
(dequeue, enqueue, waitpoint, checkpoint, run-attempt, ttl, delayed-run,
execution-snapshot, pending-version, debounce, batch) through the
resolver/store instead of talking to a single Prisma client directly.
`engine/errors.ts`, `engine/types.ts`, and `engine/index.ts` are
extended to support injecting the store/resolver.

Three fixes are included on top of the seam work:

- `c6cadd85f` — routes read-your-writes to the owning store's
**writer**, not its lagging replica, so an operation immediately reading
back what it just wrote sees a consistent result.
- `05c912e05` — normalizes run-ops-generation Prisma errors to the
control-plane error class at the store **write boundary**, so
`instanceof` checks and the `P2002` → 422 handling continue to work
across the separately-generated run-ops Prisma client.
- `88d12907f` — resolves NEW-resident batches in
`ApiBatchResultsPresenter` by routing the batch read through the store,
so a dedicated-DB batch resolves instead of returning 404.

The change is heavily test-first: the bulk of the diff is new
unit/integration coverage for the store routing, residency, and each
run-engine system's control-plane resolver path.

## Why

PR4 of the run-ops split stack (PR1–PR3 land the ClickHouse
test-container and earlier plumbing). This PR is the read-path
foundation: it adds the seam and read-routing but leaves the write path
to route through the same seam in a later PR. Behavior-changing where
the three fixes above touch existing read-your-writes /
error-normalization / batch-resolution paths; otherwise additive (new
store module, new resolver, injectable dependencies with existing
single-client behavior preserved when no dedicated store is configured).

## Tests

Extensive new vitest coverage under `run-store/src/*.test.ts` (routing,
residency, dual-schema select, cross-generation error normalization,
read-after-write, idempotency dedup, mixed residency, waitpoint
co-location) and `run-engine/src/engine/**/*.test.ts` (per-system
`controlPlaneResolver` tests, injectability, block-edge residency,
waitpoint read residency, trigger-create routing, lifecycle router).
Testcontainers-backed; no mocks.

## Notes

Draft, **stacked on #4114** (`runops/pr03-clickhouse-tc`). Review that
first; this diff is against it.

Server-change / changeset note to be added at stack-assembly time.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>