GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support aria-description by aleventhal · Pull Request #69 · w3c/accname

Conversation

@aleventhal

@aleventhal aleventhal commented Jan 14, 2020 •
edited by pr-preview Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes issue #68 and issue #77

Testing whether editing this comment triggers pr-preview.
Yay! It does! 🎉

Editing comment again now to add #mapping_additional_nd_description in-page anchor for preview.


Preview | Diff


Preview | Diff

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aaron Leventhal
Support aria-description
6d15ec1
carmacleod
carmacleod reviewed Jan 16, 2020
View reviewed changes
Comment thread index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

@aleventhal @carmacleod
Update index.html
e6bb554
Co-Authored-By: Carolyn MacLeod <[email protected]>
carmacleod
carmacleod approved these changes Jan 16, 2020
View reviewed changes

@carmacleod carmacleod left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@aleventhal

aleventhal commented Feb 14, 2020

Copy link
Copy Markdown
Contributor Author

@joanmarie what are the next steps for this one?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joanmarie

joanmarie commented Feb 18, 2020

Copy link
Copy Markdown
Contributor

@joanmarie what are the next steps for this one?

Group review, including from @accdc who is taking the lead on this spec.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joanmarie
joanmarie reviewed Feb 18, 2020
View reviewed changes
Comment thread index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

joanmarie
joanmarie requested changes Feb 18, 2020
View reviewed changes

@joanmarie joanmarie left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there also be a change in the algorithm found in https://w3c.github.io/accname/#mapping_additional_nd_te? Compare with what's there for name computation, in particular: 2B addresses name when there is an aria-labelledby. 2C addresses name when there is aria-label.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Aaron Leventhal
Remove caps
d07cb89
@aleventhal

aleventhal commented Feb 21, 2020

Copy link
Copy Markdown
Contributor Author

Hi @joanmarie, there should not be a change to the algorithm. When aria-describedby is used, it uses the name algorithm as it stands now to get the text. That algorithm does not consider description markup, it only returns the primary text.

When aria-describedby is not used, then aria-description can be used to set the description. However, aria-description does not affect the recursive algorithm, whether it's used for name or description.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aleventhal
aleventhal requested a review from accdc February 21, 2020 21:02
@joanmarie

joanmarie commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

Ok.... Though I still think it's odd that the algorithm for computing the name and description lacks any mention of aria-description. If no one else thinks so.... 🤷‍♀️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aleventhal

aleventhal commented Feb 24, 2020

Copy link
Copy Markdown
Contributor Author

Ok.... Though I still think it's odd that the algorithm for computing the name and description lacks any mention of aria-description. If no one else thinks so....

As it stands, we have these 3 headings, which is confusing already:
Accessible Name Computation
Accessible Description Computation (which mentions aria-description)
Accessible Name and Description Computation (reused by the others)

IMO the overlap between these names is kind of confusing already. The last one could be renamed "Primary Text for a Subtree Computation". Then the first two would explain that the Primary Text for a Subtree is used for aria-labelledby and aria-describedby.

But it doesn't make sense to mention aria-description in that Primary Text Computation, because that would change the way aria-description works, which is not desired.

JAWS-test and carmacleod reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JAWS-test

JAWS-test commented Feb 24, 2020

Copy link
Copy Markdown

See also #77

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joanmarie joanmarie added the Agenda label Feb 25, 2020
@joanmarie
joanmarie requested review from carmacleod and joanmarie and removed request for joanmarie February 27, 2020 18:21
@css-meeting-bot

css-meeting-bot commented Feb 27, 2020

Copy link
Copy Markdown
Member

The ARIA Working Group just discussed aria-description.

The full IRC log of that discussion <carmacleod> TOPIC: aria-description
<carmacleod> github: https://github.com//pull/69
<carmacleod> joanie: a bit weird that aria-description is not in Name & Description computation
<jamesn> q+
<carmacleod> aaronlev: confusing to have sections names "Name", "Description", and "Name & Description" - need to have a new name, maybe "Primary Text Computation"
<carmacleod> ack jamesn
<aaronlev> 1. Change third item to be "Primary text computation"
<aaronlev> 2. Change description computation to add all the attributes that might be used
<aaronlev> 3. Change primary text computation to be modeless in terms of what it's being used for
<aaronlev> Item 2 would include add aria-description
<aaronlev> ^ my proposal for 13
<aaronlev> ^ my proposal for 1.3
<carmacleod> jamesn: can we add pr-preview to the accname repo?
<carmacleod> MichaelC: yes - I'll do that
<carmacleod> carmacleod: I think I have a pr for that
<MarkMccarthy> s/^ my proposal for 13
<carmacleod> jamesn: need a preview to look at this
<MarkMccarthy> s/^ my proposal for 13/
<carmacleod> mck: how about using the name "Text Content Computation"? instead of "Primary..."
<carmacleod> aaronlev: I like that name. "Text Content Computation"
<carmacleod> aaronlev: how about if I just expand the current pr to add this?
<carmacleod> zakim, next item
<Zakim> agendum 4. "meter role should have optional aria-valuemin/max with defaults" taken up [from jamesn]
<jamesn> https://github.com/w3c/aria/issues/1123
JAWS-test reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@carmacleod

carmacleod commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

@aleventhal Notes from the meeting bot:

aaronlev: I like that name. "Text Content Computation"
aaronlev: how about if I just expand the current pr to add this?

There was general agreement (not in the notes because the scribe was lagging behind... 😄 ).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aaron Leventhal and others added 5 commits March 3, 2020 10:36
Aaron Leventhal
Support aria-description
f881e51
@aleventhal @carmacleod Aaron Leventhal
Update index.html
ddff097
Co-Authored-By: Carolyn MacLeod <[email protected]>
Aaron Leventhal
Remove caps
9cbebe9
Aaron Leventhal
Also addresses issue 77, and makes changes as discussed on ARIA WG call.
4204d6e
1. Changes "4.3 Name and Description Computation" to "4.3 Text Content
Computation", to be reused by the "4.1 Name Computation" and
"4.2 Description Computation".
2. Change Text Content Computation to be modeless in terms of what it's being
used for, in other words remove phrases like "if computing accessible name".
3. Change description computation to add all the attributes that might be used,
in precedence order, and format it in an easy-to-read table.
Aaron Leventhal
merge
124f10f
@aleventhal aleventhal mentioned this pull request Mar 3, 2020
Explanation to determine a description is meaningless #77
Closed
@aleventhal

aleventhal commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

I think this is is a step in the right direction, but doesn't solve everything.

In the table, I mention all relevant HTML markup, because currently I think the spec dances around HTML markup, yet seems to desperately want to mention it. HTML should be treated as a first class citizen by this spec, maybe even SVG too. Otherwise it's hard to define an order of markup precedence, let alone which markup should be processed. Getting names and descriptions right in HTML is too important to just hand wave around this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@accdc

accdc commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

Hi, I think this is a great step in the right direction. Please merge if you will. We will continue working on the rest as well after.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JAWS-test

JAWS-test commented Mar 4, 2020

Copy link
Copy Markdown

@aleventhal, many thanks for the comprehensive revision. I think it removes all the ambiguities and errors that were previously contained. In the preview, there is only one problem with the numbering of the list items: instead of letters, numbers are used, so that the references (e.g. "2F.i") no longer work. But maybe this is just a CSS problem of the preview.

The table for description is very good. I just think the first column header is wrong (it should be "precedence" instead of "predence", right?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aleventhal

aleventhal commented Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

@accdc I'm not authorized to merge, unfortunately. Do you want to authorize me or merge?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@accdc

accdc commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

I'm never going to be as good with github as others here, so if you or Melanie could help with this I'd appreciate it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cookiecrook cookiecrook self-assigned this Sep 29, 2022
@cookiecrook

cookiecrook commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

From call: Dependent on #433? @scottaohara

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cookiecrook and others added 2 commits September 29, 2022 11:58
@cookiecrook
Apply suggestions from code review
1a1ba74
Committing some diffs from prior review (with editor's and WG's blessing)
@jnurthen
Merge branch 'main' into aria-description
31ff4d7
@jnurthen
jnurthen marked this pull request as draft October 6, 2022 17:46
@jnurthen jnurthen unassigned aleventhal and scottaohara Oct 6, 2022
cookiecrook
cookiecrook reviewed Oct 25, 2022
View reviewed changes
Comment thread index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

@cookiecrook
Typo correction from Scott
27edc51
@scottaohara scottaohara self-assigned this Oct 27, 2022
@scottaohara
revise description table to ref updated HTML AAM
655e761
Remove specific references to the unique HTML elements from the table.  Replaced these rows with a new row indicating there may be host language features which participating in the description computation, and to look at HTML AAM for the elements which are applicable.
scottaohara added a commit to w3c/html-aam that referenced this pull request Oct 28, 2022
@scottaohara
further alignment with accName description updates
5347902
This PR is necessary to fully address the needs of the accName PR - w3c/accname#69

- New language has been added to the introduction of this section, better aligning it with the normative text of accName's new 4.2 section.
- cut down item 1 the text was redundant per the new language added to the introduction of the section.
- Modified each of the section 2 items to align with the accName table column "how to compute description".
- Revised the final item (4) to align with the accName normative text, and the revised introduction of this section, stating that UAs are even expected to return an empty description.
@scottaohara scottaohara mentioned this pull request Oct 28, 2022
further alignment with accName description updates w3c/html-aam#444
Merged
@scottaohara
scottaohara marked this pull request as ready for review October 28, 2022 13:51
@scottaohara scottaohara mentioned this pull request Oct 28, 2022
Other elements which may need special description computation conditions? w3c/html-aam#445
Open
@mcking65

mcking65 commented Nov 3, 2022

Copy link
Copy Markdown

Do we intend the aria-description value on an element to be able to be included in its description by a self-reference in the value of aria-describedby?

If so, that does not appear to be supported by the current definition of aria-describedby computation.

If not, we may want to make that constraint more clear. It would make the behavior of aria-describedby slightly different from the behavior of aria-labelledby.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JAWS-test

JAWS-test commented Nov 4, 2022

Copy link
Copy Markdown

Do we intend the aria-description value on an element to be able to be included in its description by a self-reference in the value of aria-describedby?

I don't think that makes sense. If elements are referenced by aria-describedby, then their AccName is relevant and not their AccDesc. I.e. the AccName of an element becomes the AccDesc of the element which is referred to by aria-describedby. The AccDesc of an element does not matter (whether via title, aria-description or any other method) if the element is referenced via aria-describedby.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jnurthen jnurthen mentioned this pull request Nov 4, 2022
Add steps for ariaLabelledByElements and ariaDescribedByElements #170
Closed
@cookiecrook
cookiecrook self-requested a review November 10, 2022 18:49
cookiecrook
cookiecrook approved these changes Nov 10, 2022
View reviewed changes
Comment thread index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

scottaohara and others added 2 commits November 10, 2022 15:35
@scottaohara @cookiecrook
Update index.html
9cfc129
Co-authored-by: James Craig <[email protected]>
@jnurthen
Merge branch 'main' into aria-description
a438283
MelSumner
MelSumner approved these changes Nov 28, 2022
View reviewed changes
@MelSumner MelSumner removed the Agenda label Nov 28, 2022
@MelSumner
MelSumner merged commit 81361ec into main Nov 28, 2022
github-actions Bot added a commit that referenced this pull request Nov 28, 2022
@aleventhal @github-actions
Support aria-description (#69)
f80cc90
SHA: 81361ec
Reason: push, by MelSumner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@MelSumner MelSumner mentioned this pull request Nov 28, 2022
Clarify: should aria-description be able to self-reference like aria-labelledby? #176
Closed
@JAWS-test JAWS-test mentioned this pull request Dec 7, 2022
Clarify description computation for aria-describedby #177
Merged
@pkra pkra mentioned this pull request Jun 27, 2023
Support ARIA 1.3's aria-description property #68
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carmacleod carmacleod carmacleod approved these changes
@scottaohara scottaohara scottaohara left review comments
@cookiecrook cookiecrook cookiecrook approved these changes
@joanmarie joanmarie joanmarie approved these changes
@MelSumner MelSumner MelSumner approved these changes
@accdc accdc Awaiting requested review from accdc

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@cookiecrook cookiecrook

@scottaohara scottaohara

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@aleventhal @joanmarie @JAWS-test @css-meeting-bot @carmacleod @accdc @jcsteh @cookiecrook @scottaohara @MelSumner @jnurthen @mcking65
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.