GeezerVison is showing static-codereview.wikimedia.org — r82200 MediaWiki - Code Review archive
r82200 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r82199 | r82200 | r82201 > |
| Date: | 22:14, 15 February 2011 |
| Author: | tparscal |
| Status: | ok |
| Tags: | |
| Comment: | Grouped diff and history modules together to help reduce cache invalidation. Loaded diff styles statically. This should help with bug #27418, but I suspect there are more cases where we need to do this sort of thing before the bug is truly resolved. |
| Modified paths: |
- /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)
- /trunk/phase3/resources/Resources.php (modified) (history)
|
| Index: trunk/phase3/includes/diff/DifferenceEngine.php |
| — | — | @@ -584,7 +584,8 @@ |
| 585 | 585 | */ |
| 586 | 586 | function showDiffStyle() { |
| 587 | 587 | global $wgOut; |
| 588 | | - $wgOut->addModules( 'mediawiki.legacy.diff' ); |
| | 588 | + $wgOut->addModuleStyles( 'mediawiki.legacy.diff' ); |
| | 589 | + $wgOut->addModuleScripts( 'mediawiki.legacy.diff' ); |
| 589 | 590 | } |
| 590 | 591 | |
| 591 | 592 | /** |
| Index: trunk/phase3/resources/Resources.php |
| — | — | @@ -399,6 +399,7 @@ |
| 400 | 400 | 'mediawiki.action.history' => array( |
| 401 | 401 | 'scripts' => 'resources/mediawiki.action/mediawiki.action.history.js', |
| 402 | 402 | 'dependencies' => 'mediawiki.legacy.history', |
| | 403 | + 'group' => 'mediawiki.action.history', |
| 403 | 404 | ), |
| 404 | 405 | 'mediawiki.action.edit' => array( |
| 405 | 406 | 'scripts' => 'resources/mediawiki.action/mediawiki.action.edit.js', |
| — | — | @@ -522,6 +523,7 @@ |
| 523 | 524 | 'mediawiki.legacy.diff' => array( |
| 524 | 525 | 'scripts' => 'common/diff.js', |
| 525 | 526 | 'styles' => 'common/diff.css', |
| | 527 | + 'group' => 'mediawiki.action.history', |
| 526 | 528 | 'remoteBasePath' => $GLOBALS['wgStylePath'], |
| 527 | 529 | 'localBasePath' => "{$GLOBALS['IP']}/skins", |
| 528 | 530 | 'dependencies' => 'mediawiki.legacy.wikibits', |
| — | — | @@ -534,6 +536,7 @@ |
| 535 | 537 | ), |
| 536 | 538 | 'mediawiki.legacy.history' => array( |
| 537 | 539 | 'scripts' => 'common/history.js', |
| | 540 | + 'group' => 'mediawiki.action.history', |
| 538 | 541 | 'remoteBasePath' => $GLOBALS['wgStylePath'], |
| 539 | 542 | 'localBasePath' => "{$GLOBALS['IP']}/skins", |
| 540 | 543 | 'dependencies' => 'mediawiki.legacy.wikibits', |
Follow-up revisions
| Revision | Commit summary | Author | Date |
|---|
| r82220 | 1.17wmf1: MFT r80495, r80765, r81177, r82000, r82155, r82156, r82191, r82200,... | catrope | 07:23, 16 February 2011 |
| r85151 | MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ... | demon | 20:39, 1 April 2011 |
| r85348 | Fixes for r85151: grab Resources.php changes for r81719, r81721, r81722, r822... | demon | 17:41, 4 April 2011 |
Status & tagging log
- 20:40, 1 April 2011 😂 (talk | contribs) changed the tags for r82200 [removed: 1.17]
- 07:24, 16 February 2011 Catrope (talk | contribs) changed the tags for r82200 [removed: 1.17wmf1]
- 07:23, 16 February 2011 Catrope (talk | contribs) changed the tags for r82200 [added: 1.17]
- 07:23, 16 February 2011 Catrope (talk | contribs) changed the tags for r82200 [removed: 1.17]
- 22:15, 15 February 2011 Catrope (talk | contribs) changed the tags for r82200 [added: 1.17,1.17wmf1]
- 22:15, 15 February 2011 Catrope (talk | contribs) changed the status of r82200 [removed: new added: ok]
|