GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Google Spanner support by s13o · Pull Request #1415 · JSQLParser/JSqlParser

Conversation

@s13o

@s13o s13o commented Nov 11, 2021

Copy link
Copy Markdown

add support of a Google Spanner Interleaved table, commit timestamp options and array types

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@s13o

s13o commented Nov 18, 2021

Copy link
Copy Markdown
Author

Any comments, suggestions, confusions so far?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Greetings,

thank you for sending this PR, it looks good to me. But only the owner of the software @wumpz will be able to merge it and he is very busy at the moment. Please have patience, thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects

manticore-projects commented Nov 28, 2021

Copy link
Copy Markdown
Contributor

Greetings, you would need to resolve the conflicts and re-submit please.
(Just in case: Pull/Merger from MASTER into your repository, resolve conflicts, commit and push into your GitHub).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@s13o
add support of a Google Spanner Interleaved table, commit timestamp o…
010d611 
…ptions and array types
@s13o
s13o force-pushed the spanner branch from ec4c9c6 to 010d611 Compare November 29, 2021 16:34
manticore-projects
manticore-projects reviewed Nov 29, 2021
View reviewed changes
Comment thread src/main/java/net/sf/jsqlparser/statement/create/table/CreateTable.java
}
String options = PlainSelect.getStringList(tableOptionsStrings, false, false);
if (options != null && options.length() > 0) {
if (!options.isEmpty()) {

@manticore-projects manticore-projects Nov 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really NULL safe? In JSQLParser, we have (unfortunately) a lot of Lists which can be NULL.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@s13o s13o Nov 29, 2021

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a StringBuilder result from the PlainSelect#getStringList(...)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@manticore-projects manticore-projects Nov 29, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for checking.
isEmpty is available on Java 8? I recall it was available in Java 11 only?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@s13o s13o Nov 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it is available, since 1.6
Maven build would fail otherwise but it was passed fine

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@manticore-projects manticore-projects Nov 29, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry for bothering you.

Thanks for the PR, it looks very good in my opinion, well done.
But only @wumpz can merge it eventually. Please be patient.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@s13o s13o Dec 14, 2021

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to have it merged this year?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@s13o s13o Jun 7, 2022

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the project abandoned?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@manticore-projects manticore-projects Jun 8, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project is very active and as accepted a few PRs since your contribution.
Thus you will need to resolve conflicts first (Pull + Merge + Resolve Conflicts + Commit + Push), before your PR can be accepted.

Thank you for understanding.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
manticore-projects
manticore-projects approved these changes Nov 29, 2021
View reviewed changes
@wumpz

wumpz commented Jun 28, 2022

Copy link
Copy Markdown
Member

@manticore-projects Is this still active?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects added a commit to manticore-projects/JSqlParser that referenced this pull request Dec 9, 2022
@manticore-projects
feat: Google Spanner Support
b4eb8d8 
Replaces PR JSQLParser#1415, all credit goes to @s13o
Re-arranged some recently added Tokens in alphabetical order
Update Keywords
@manticore-projects manticore-projects mentioned this pull request Dec 9, 2022
Assorted Fixes #4 #1676
Merged
@manticore-projects

manticore-projects commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Salvaged into PR #1676.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects manticore-projects closed this Dec 9, 2022
wumpz pushed a commit that referenced this pull request Dec 22, 2022
@manticore-projects Zhang Zhongliang
Assorted Fixes #4 (#1676)
8d9db70 
* support clickhouse global keyword in join

* fix: add missing public Getter

Add public Getter for `updateSets`
Fixes #1630

* feat: Clickhouse GLOBAL JOIN

All credits to @julianzlzhang

fixes #1615
fixes #1535

* feat: IF/ELSE statements supports Block

Make `If... Else...` statements work with Blocks
Make `Statement()` production work with `Block()`
Rewrite the `Block()` related Unit Tests

fixes #1682

* fix: Revert unintended changes to the Special Oracle Tests

* fix: `SET` statement supports `UserVariable`

Make `SetStatement` parse Objects instead of Names only
Add Grammar to accept `UserVariable` (e.g. "set @Flag = 1")
Add Test Case for `UserVariable`

fixes #1682

* feat: Google Spanner Support

Replaces PR #1415, all credit goes to @s13o
Re-arranged some recently added Tokens in alphabetical order
Update Keywords

* fix: fix JSonExpression, accept Expressions

Make JSonExpression accept Expressions
Add Testcase
Expose Idents() and Operators()
Fixes #1696

* test: add Test for Issue #1237

Co-authored-by: Zhang Zhongliang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manticore-projects manticore-projects manticore-projects approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@s13o @manticore-projects @wumpz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.