GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — support clickhouse global keyword in join by julianzlzhang · Pull Request #1615 · JSQLParser/JSqlParser

Conversation

@julianzlzhang

@julianzlzhang julianzlzhang commented Aug 16, 2022

Copy link
Copy Markdown

Support GLOBAL keyword for JOIN in ClickHouse.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Zhang Zhongliang
support clickhouse global keyword in join
35ebbc5
@manticore-projects

manticore-projects commented Aug 16, 2022

Copy link
Copy Markdown
Contributor

Looks good to me, please approve.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wumpz

wumpz commented Aug 31, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

JSqlParser enforces some coding rules you are violating in your PR. A complete maven build does not succeed in your branch. Please correct that.

Error:  src/main/java/net/sf/jsqlparser/statement/select/Join.java:[311,9] (whitespace) WhitespaceAfter: 'if' is not followed by whitespace.
Error:  src/main/java/net/sf/jsqlparser/util/deparser/SelectDeParser.java:[402,9] (whitespace) WhitespaceAfter: 'if' is not followed by whitespace.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nettm

nettm commented Nov 21, 2022

Copy link
Copy Markdown

When will this problem be solved?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wumpz

wumpz commented Nov 27, 2022

Copy link
Copy Markdown
Member

@julianzlzhang When do you solve your PRs problems? Look into failing checkstyle verification.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
manticore-projects added a commit to manticore-projects/JSqlParser that referenced this pull request Nov 28, 2022
@manticore-projects
feat: Clickhouse GLOBAL JOIN
7086f18 
All credits to @julianzlzhang

fixes JSQLParser#1615
fixes JSQLParser#1535
@manticore-projects manticore-projects mentioned this pull request Nov 28, 2022
Assorted Fixes #4 #1676
Merged
@manticore-projects

manticore-projects commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

I have salvaged this PR into #1676
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manticore-projects manticore-projects closed this Nov 28, 2022
wumpz pushed a commit that referenced this pull request Dec 22, 2022
@manticore-projects Zhang Zhongliang
Assorted Fixes #4 (#1676)
8d9db70 
* support clickhouse global keyword in join

* fix: add missing public Getter

Add public Getter for `updateSets`
Fixes #1630

* feat: Clickhouse GLOBAL JOIN

All credits to @julianzlzhang

fixes #1615
fixes #1535

* feat: IF/ELSE statements supports Block

Make `If... Else...` statements work with Blocks
Make `Statement()` production work with `Block()`
Rewrite the `Block()` related Unit Tests

fixes #1682

* fix: Revert unintended changes to the Special Oracle Tests

* fix: `SET` statement supports `UserVariable`

Make `SetStatement` parse Objects instead of Names only
Add Grammar to accept `UserVariable` (e.g. "set @Flag = 1")
Add Test Case for `UserVariable`

fixes #1682

* feat: Google Spanner Support

Replaces PR #1415, all credit goes to @s13o
Re-arranged some recently added Tokens in alphabetical order
Update Keywords

* fix: fix JSonExpression, accept Expressions

Make JSonExpression accept Expressions
Add Testcase
Expose Idents() and Operators()
Fixes #1696

* test: add Test for Issue #1237

Co-authored-by: Zhang Zhongliang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@julianzlzhang @manticore-projects @wumpz @nettm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.